Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1387833002: Print response from the server on HTTP errors from Rietveld (Closed)

Created:
5 years, 2 months ago by Sergiy Byelozyorov
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print response from the server on HTTP errors from Rietveld This will make explanation provided by Rietveld visible to the user, e.g. "Request to https://codereview.chromium.org/1386443003/edit_flags failed: Cannot set commit on an issue that does not have a commit queue". R=phajdan.jr@chromium.org BUG=529339 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M rietveld.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sergiy Byelozyorov
5 years, 2 months ago (2015-10-05 13:16:17 UTC) #1
Sergiy Byelozyorov
Also adding Jason in case he knows why we shouldn't print this output.
5 years, 2 months ago (2015-10-05 13:17:47 UTC) #3
Paweł Hajdan Jr.
LGTM
5 years, 2 months ago (2015-10-05 13:42:56 UTC) #4
jrobbins
lgtm
5 years, 2 months ago (2015-10-05 15:29:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387833002/1
5 years, 2 months ago (2015-10-05 15:40:25 UTC) #7
Sergiy Byelozyorov
+tandrii for OWNERS
5 years, 2 months ago (2015-10-05 15:41:09 UTC) #9
tandrii(chromium)
rs lgtm
5 years, 2 months ago (2015-10-05 15:43:49 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 15:45:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297009

Powered by Google App Engine
This is Rietveld 408576698