Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138783002: Cleans up gyp file for views example and removes duplicate code (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Cleans up gyp file for views example and removes duplicate code BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245011

Patch Set 1 #

Patch Set 2 : fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -379 lines) Patch
M ui/views/controls/combobox/combobox_listener.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/single_split_view_listener.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane_listener.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/table/table_grouper.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/controls/table/table_view_observer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/examples/bubble_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/button_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/checkbox_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/combobox_example.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/examples/double_split_view_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/example_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/examples_main.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/examples/examples_window.h View 1 chunk +15 lines, -2 lines 0 comments Download
M ui/views/examples/examples_window.cc View 7 chunks +93 lines, -70 lines 0 comments Download
M ui/views/examples/examples_window_with_content.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/examples/examples_window_with_content.cc View 1 chunk +4 lines, -206 lines 0 comments Download
M ui/views/examples/label_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/link_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/menu_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/message_box_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/multiline_example.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/progress_bar_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/radio_button_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/scroll_view_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/single_split_view_example.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/examples/slider_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/examples/tabbed_pane_example.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/table_example.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/examples/text_example.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/textfield_example.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/throbber_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/tree_view_example.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/examples/widget_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 11 months ago (2014-01-14 19:50:43 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-14 20:47:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/138783002/1
6 years, 11 months ago (2014-01-15 05:25:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=140528
6 years, 11 months ago (2014-01-15 18:47:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/138783002/520001
6 years, 11 months ago (2014-01-15 18:49:42 UTC) #5
sky
6 years, 11 months ago (2014-01-15 23:04:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r245011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698