Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: runtime/vm/flow_graph_optimizer.h

Issue 13878017: Convert EqualityCompare to StrictCompare if reciever is either null or guaranteed to have default e… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Srdjan's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_ 5 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_
6 #define VM_FLOW_GRAPH_OPTIMIZER_H_ 6 #define VM_FLOW_GRAPH_OPTIMIZER_H_
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 #include "vm/flow_graph.h" 9 #include "vm/flow_graph.h"
10 10
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 MethodRecognizer::Kind recognized_kind); 148 MethodRecognizer::Kind recognized_kind);
149 149
150 void HandleRelationalOp(RelationalOpInstr* comp); 150 void HandleRelationalOp(RelationalOpInstr* comp);
151 151
152 // Visit an equality compare. The current instruction can be the 152 // Visit an equality compare. The current instruction can be the
153 // comparison itself or a branch on the comparison. 153 // comparison itself or a branch on the comparison.
154 template <typename T> 154 template <typename T>
155 void HandleEqualityCompare(EqualityCompareInstr* comp, 155 void HandleEqualityCompare(EqualityCompareInstr* comp,
156 T current_instruction); 156 T current_instruction);
157 157
158 static bool CanStrictifyEqualityCompare(EqualityCompareInstr* call);
159
160 template <typename T>
161 bool StrictifyEqualityCompare(EqualityCompareInstr* compare,
162 T current_instruction) const;
163
158 void OptimizeLeftShiftBitAndSmiOp(Definition* bit_and_instr, 164 void OptimizeLeftShiftBitAndSmiOp(Definition* bit_and_instr,
159 Definition* left_instr, 165 Definition* left_instr,
160 Definition* right_instr); 166 Definition* right_instr);
161 167
162 void AddToGuardedFields(Field* field); 168 void AddToGuardedFields(Field* field);
163 169
164 FlowGraph* flow_graph_; 170 FlowGraph* flow_graph_;
165 GrowableArray<Field*>* guarded_fields_; 171 GrowableArray<Field*>* guarded_fields_;
166 172
167 DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer); 173 DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer);
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 // platform. 315 // platform.
310 class IfConverter : public AllStatic { 316 class IfConverter : public AllStatic {
311 public: 317 public:
312 static void Simplify(FlowGraph* flow_graph); 318 static void Simplify(FlowGraph* flow_graph);
313 }; 319 };
314 320
315 321
316 } // namespace dart 322 } // namespace dart
317 323
318 #endif // VM_FLOW_GRAPH_OPTIMIZER_H_ 324 #endif // VM_FLOW_GRAPH_OPTIMIZER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698