chromeos: Return error from DriveResourceMetadata when there is no sufficient disk space

chrome/browser/chromeos/drive/drive_resource_metadata.cc

Index: chrome/browser/chromeos/drive/drive_resource_metadata.cc
diff --git a/chrome/browser/chromeos/drive/drive_resource_metadata.cc b/chrome/browser/chromeos/drive/drive_resource_metadata.cc
index 5106cc76b247195c079840999742f7c53d914aab..4c1217824a9f09091e3ddf7f7a532b68d6952bef 100644
--- a/chrome/browser/chromeos/drive/drive_resource_metadata.cc
+++ b/chrome/browser/chromeos/drive/drive_resource_metadata.cc
@@ -7,6 +7,7 @@
 #include "base/file_util.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/sys_info.h"
 #include "chrome/browser/chromeos/drive/drive.pb.h"
 #include "chrome/browser/chromeos/drive/drive_file_system_util.h"
 #include "chrome/browser/chromeos/drive/drive_resource_metadata_storage.h"
@@ -42,6 +43,14 @@ void RunGetChildDirectoriesCallbackWithResult(
   callback.Run(*result);
 }
 
+// Returns true if enough disk space is avilable for DB operation.
+// TODO(hashimoto): Merge this with DriveCache's FreeDiskSpaceGetterInterface.
+bool EnoughDiskSpaceIsAvailableForDBOperation(const base::FilePath& path) {
+  const int64 kRequiredDiskSpaceInMB = 128;

[hidehiko, 2013/04/18 12:45:48]

Could you add comments the background about why 128MB is required?

[hashimoto, 2013/04/18 13:06:56]

Done.

+  return base::SysInfo::AmountOfFreeDiskSpace(path) >=
+      kRequiredDiskSpaceInMB*(1 << 20);

[hidehiko, 2013/04/18 12:45:48]

nit: s/*/ * /

[hashimoto, 2013/04/18 13:06:56]

Done.

+}
+
 }  // namespace
 
 std::string DirectoryFetchInfo::ToString() const {
@@ -201,6 +210,9 @@ DriveResourceMetadata::~DriveResourceMetadata() {
 DriveFileError DriveResourceMetadata::InitializeOnBlockingPool() {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return DRIVE_FILE_ERROR_NO_SPACE;
+
   // Initialize the storage.
   if (!storage_->Initialize())
     return DRIVE_FILE_ERROR_FAILED;
@@ -235,6 +247,12 @@ void DriveResourceMetadata::DestroyOnBlockingPool() {
 void DriveResourceMetadata::ResetOnBlockingPool() {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  // TODO(hashimoto): Return DRIVE_FILE_ERROR_NO_SPACE here.
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_)) {
+    LOG(ERROR) << "Required disk space not available.";
+    return;
+  }
+
   RemoveAllOnBlockingPool();
   storage_->SetLargestChangestamp(0);
 }
@@ -451,6 +469,10 @@ int64 DriveResourceMetadata::GetLargestChangestampOnBlockingPool() {
 DriveFileError DriveResourceMetadata::SetLargestChangestampOnBlockingPool(
     int64 value) {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
+
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return DRIVE_FILE_ERROR_NO_SPACE;
+
   storage_->SetLargestChangestamp(value);
   return DRIVE_FILE_OK;
 }
@@ -463,6 +485,9 @@ DriveResourceMetadata::MoveEntryToDirectoryOnBlockingPool(
   DCHECK(!directory_path.empty());
   DCHECK(!file_path.empty());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return FileMoveResult(DRIVE_FILE_ERROR_NO_SPACE);
+
   scoped_ptr<DriveEntryProto> entry = FindEntryByPathSync(file_path);
   if (!entry)
     return FileMoveResult(DRIVE_FILE_ERROR_NOT_FOUND);
@@ -498,6 +523,10 @@ DriveResourceMetadata::RenameEntryOnBlockingPool(
   DCHECK(!new_name.empty());
 
   DVLOG(1) << "RenameEntry " << file_path.value() << " to " << new_name;
+
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return FileMoveResult(DRIVE_FILE_ERROR_NO_SPACE);
+
   scoped_ptr<DriveEntryProto> entry = FindEntryByPathSync(file_path);
   if (!entry)
     return FileMoveResult(DRIVE_FILE_ERROR_NOT_FOUND);
@@ -516,6 +545,9 @@ DriveResourceMetadata::RemoveEntryOnBlockingPool(
     const std::string& resource_id) {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))

[hidehiko, 2013/04/18 12:45:48]

Is it necessary to check disk space for removing operations, too?

[hashimoto, 2013/04/18 13:06:56]

Yes, sometimes it results in adding an entry to the DB and might result in
compaction. (see http://leveldb.googlecode.com/svn/trunk/doc/impl.html for
details.)

+    return FileMoveResult(DRIVE_FILE_ERROR_NO_SPACE);
+
   // Disallow deletion of special entries "/drive" and "/drive/other".
   if (util::IsSpecialResourceId(resource_id))
     return FileMoveResult(DRIVE_FILE_ERROR_ACCESS_DENIED);
@@ -635,6 +667,11 @@ DriveResourceMetadata::RefreshEntryOnBlockingPool(
     const DriveEntryProto& entry_proto) {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_)) {
+    return make_scoped_ptr(
+        new GetEntryInfoWithFilePathResult(DRIVE_FILE_ERROR_NO_SPACE));
+  }
+
   scoped_ptr<DriveEntryProto> entry =
       storage_->GetEntry(entry_proto.resource_id());
   if (!entry) {
@@ -678,6 +715,9 @@ DriveResourceMetadata::RefreshDirectoryOnBlockingPool(
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
   DCHECK(!directory_fetch_info.empty());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return FileMoveResult(DRIVE_FILE_ERROR_NO_SPACE);
+
   scoped_ptr<DriveEntryProto> directory = storage_->GetEntry(
       directory_fetch_info.resource_id());
 
@@ -734,6 +774,9 @@ DriveResourceMetadata::AddEntryOnBlockingPool(
     const DriveEntryProto& entry_proto) {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_))
+    return FileMoveResult(DRIVE_FILE_ERROR_NO_SPACE);
+
   scoped_ptr<DriveEntryProto> existing_entry =
       storage_->GetEntry(entry_proto.resource_id());
   if (existing_entry)
@@ -805,6 +848,12 @@ void DriveResourceMetadata::GetDescendantDirectoryPaths(
 void DriveResourceMetadata::RemoveAllOnBlockingPool() {
   DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
 
+  // TODO(hashimoto): Return DRIVE_FILE_ERROR_NO_SPACE here.
+  if (!EnoughDiskSpaceIsAvailableForDBOperation(data_directory_path_)) {
+    LOG(ERROR) << "Required disk space not available.";
+    return;
+  }
+
   RemoveDirectoryChildren(util::kDriveGrandRootSpecialResourceId);
   SetUpDefaultEntries();
 }