Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13878010: Merge WebUILoginDisplayHost into LoginDisplayHostImpl (Closed)

Created:
7 years, 8 months ago by Nikita (slow)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge WebUILoginDisplayHost into LoginDisplayHostImpl BUG=124218 TEST=existing browser_tests, autotests TBR=ben Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195442

Patch Set 1 #

Patch Set 2 : mv #

Patch Set 3 : merge #

Patch Set 4 : preserve dtor order #

Patch Set 5 : cleanup #

Patch Set 6 : merge #

Patch Set 7 : pass screen parameters by scoped_ptr #

Patch Set 8 : merge + move method definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -662 lines) Patch
M chrome/browser/automation/automation_util.cc View 1 2 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 3 4 5 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 4 5 6 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 4 5 6 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host.h View 1 2 3 4 5 6 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.h View 1 2 3 4 5 6 6 chunks +103 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 2 3 4 5 6 18 chunks +409 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_display_host.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_login_display_host.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
D chrome/browser/chromeos/login/webui_login_display_host.h View 1 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/chromeos/login/webui_login_display_host.cc View 1 2 3 4 5 1 chunk +0 lines, -424 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 5 6 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nikita (slow)
Just moving methods and changing declaration a bit. No functionality changes except adding GetWebUILoginView() to ...
7 years, 8 months ago (2013-04-18 14:03:42 UTC) #1
Denis Kuznetsov (DE-MUC)
lgtm
7 years, 8 months ago (2013-04-19 12:52:51 UTC) #2
Nikita (slow)
TBR'ing Ben for renames in chrome/browser/automation/* and chrome/chrome_browser_chromeos.gypi
7 years, 8 months ago (2013-04-22 04:22:36 UTC) #3
Nikita (slow)
TBR'ing Ben for renames in chrome/browser/automation/* and chrome/chrome_browser_chromeos.gypi
7 years, 8 months ago (2013-04-22 04:23:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/13878010/35001
7 years, 8 months ago (2013-04-22 04:27:38 UTC) #5
Nikita (slow)
cros_x86 and cros_amd64 trybots are failing with something unrelated (for several days already) - Webkit/V8 ...
7 years, 8 months ago (2013-04-22 04:39:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, cacheinvalidation_unittests, chromedriver2_unittests, components_unittests, crypto_unittests, interactive_ui_tests ...
7 years, 8 months ago (2013-04-22 05:04:49 UTC) #7
Nikita (slow)
7 years, 8 months ago (2013-04-22 05:22:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 manually as r195442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698