Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1387773002: Oilpan: fix build after r352251. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, asanka, benjhayden+dwatch_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r352251. TBR=oilpan-reviews BUG=495801 Committed: https://crrev.com/a0016b20f1a6531528c101888c4c681f0e05abdc Cr-Commit-Position: refs/heads/master@{#352272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sof
5 years, 2 months ago (2015-10-04 05:51:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387773002/1
5 years, 2 months ago (2015-10-04 05:51:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-04 06:59:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0016b20f1a6531528c101888c4c681f0e05abdc Cr-Commit-Position: refs/heads/master@{#352272}
5 years, 2 months ago (2015-10-04 07:00:29 UTC) #5
haraken
LGTM
5 years, 2 months ago (2015-10-04 08:14:21 UTC) #6
yosin_UTC9
5 years, 2 months ago (2015-10-05 04:14:20 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1370203007/ by yosin@chromium.org.

The reason for reverting is: For reverting http://crrev.com/1381693002.

Powered by Google App Engine
This is Rietveld 408576698