Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: content/public/browser/content_browser_client.h

Issue 13877028: Renderer initiated navigations from non instant process should not fall into instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding tests. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 5047f6450cc854910e6fc52fe56e169e9e038b59..33879cac9168e9252bcbdce5ac99fb0746707acf 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -142,6 +142,18 @@ class CONTENT_EXPORT ContentBrowserClient {
// Notifies that a BrowserChildProcessHost has been created.
virtual void BrowserChildProcessHostCreated(BrowserChildProcessHost* host) {}
+ // Returns a privileged site version of the given URL if allowed. When
+ // transitioning across SiteInstances during navigation, the "site" of the
+ // SiteInstance may be determine by navigation properties such as
+ // "is_renderer_initiated" etc. Since SiteInstance does not take into account
+ // such factors, this calls allows clients to rewrite the URL so that their
+ // sites embedd this info.
Charlie Reis 2013/05/01 01:17:54 This comment is the most important thing to get ri
Shishir 2013/05/01 07:56:14 Done.
+ virtual GURL GetPossiblyPrivilegedURL(
+ content::BrowserContext* browser_context,
+ const GURL& url,
+ bool is_renderer_initiated,
+ SiteInstance* curr_instance);
Charlie Reis 2013/05/01 01:17:54 nit: current_instance (Since this is a public API
Shishir 2013/05/01 07:56:14 Done.
+
// Get the effective URL for the given actual URL, to allow an embedder to
// group different url schemes in the same SiteInstance.
virtual GURL GetEffectiveURL(BrowserContext* browser_context,

Powered by Google App Engine
This is Rietveld 408576698