Issue 13877023: Start putting absolute paths in generated files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13877023: Start putting absolute paths in generated files.

Created:
7 years, 8 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:

CC:
blink-reviews, caseq+blink_chromium.org, aandrey+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Start putting absolute paths in generated files. Generated headers can be included by various targets (webkit API, bindings, ...), and if these paths aren't absolute then each target including a generated header needs to pass several include paths. For idl files, the idea is that the .h file for each .idl file needs to be in the same folder. This is true for all but 3 idl files at the moment; move the other 3. XXX not done BUG=

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -142 lines)			Patch
M	Source/bindings/derived_sources.gyp	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/CodeGenerator.pm	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/CodeGeneratorV8.pm	View	1 2	8 chunks	+26 lines, -11 lines	0 comments	Download
A +	Source/bindings/v8/JavaScriptCallFrame.idl	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/bindings/v8/ScriptProfile.idl	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/bindings/v8/ScriptProfileNode.idl	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/core.gypi	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/core.gyp/core.gyp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
D	Source/core/inspector/JavaScriptCallFrame.idl	View		1 chunk	+0 lines, -54 lines	0 comments	Download
D	Source/core/inspector/ScriptProfile.idl	View		1 chunk	+0 lines, -34 lines	0 comments	Download
D	Source/core/inspector/ScriptProfileNode.idl	View		1 chunk	+0 lines, -39 lines	0 comments	Download

Issue 13877023: Start putting absolute paths in generated files.

Description

Patch Set 1 #

Patch Set 2 : .in #

Patch Set 3 : rebase #