Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 13877016: Revert 195316 "Remove "Use billing for shipping" checkbox in fav..." (Closed)

Created:
7 years, 8 months ago by Mike Wittman
Modified:
7 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195316 "Remove "Use billing for shipping" checkbox in fav..." Breaks Mac ASAN compile: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASAN%20Builder&number=19054 > Remove "Use billing for shipping" checkbox in favor of item in suggestions menu. > > BUG=225093 > > Review URL: https://codereview.chromium.org/14129005 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -199 lines) Patch
M trunk/src/chrome/android/java/res/layout/autofill_general_layout.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java View 6 chunks +21 lines, -5 lines 0 comments Download
M trunk/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java View 2 chunks +13 lines, -4 lines 0 comments Download
M trunk/src/chrome/app/generated_resources.grd View 2 chunks +2 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/autofill/autofill_dialog_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc View 4 chunks +10 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 4 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 20 chunks +45 lines, -109 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_models.h View 3 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_models.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_types.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/autofill/autofill_dialog_views.h View 3 chunks +6 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 8 chunks +32 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Wittman
7 years, 8 months ago (2013-04-19 22:43:36 UTC) #1
Mike Wittman
7 years, 8 months ago (2013-04-19 22:43:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195320.

Powered by Google App Engine
This is Rietveld 408576698