Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 13877013: Revert 194740 "Explicitly pass "--diff-cmd diff" to "svn diff", ..." (Closed)

Created:
7 years, 8 months ago by jam
Modified:
7 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194740 "Explicitly pass "--diff-cmd diff" to "svn diff", ..." On Windows, I got the following error: f:\src\chrome2\src>gcl commit n3d2 Loaded authentication cookies from C:\Users\jabdelmalek/.codereview_upload_cookies Running presubmit commit checks ... checking owners took a long time: 906ms Got an exception Command svn diff --diff-cmd diff --config-dir c:\users\jabdel~1\appdata\local\temp\tmpu7bui5 content\browser\web_content s\web_contents_impl.cc returned non-zero exit status 1 in f:\src\chrome2\src Index: content/browser/web_contents/web_contents_impl.cc =================================================================== svn: Can't start process 'diff': The system cannot find the file specified. > Explicitly pass "--diff-cmd diff" to "svn diff", for users who have set some other diff tool. > > Review URL: https://chromiumcodereview.appspot.com/14130006 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M trunk/tools/depot_tools/scm.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 8 months ago (2013-04-18 16:46:14 UTC) #1
Peter Kasting
7 years, 8 months ago (2013-04-18 18:34:55 UTC) #2
Message was sent while issue was closed.
LGTM, thanks; this was the wrong way to implement this.

Powered by Google App Engine
This is Rietveld 408576698