Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: runtime/vm/simulator_arm.cc

Issue 1387643002: Move vm_tags from isolate to thread, since we may have multiple threads in same isolate (GC, backgr… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: More comment cleanups Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <setjmp.h> // NOLINT 5 #include <setjmp.h> // NOLINT
6 #include <stdlib.h> 6 #include <stdlib.h>
7 7
8 #include "vm/globals.h" 8 #include "vm/globals.h"
9 #if defined(TARGET_ARCH_ARM) 9 #if defined(TARGET_ARCH_ARM)
10 10
(...skipping 3850 matching lines...) Expand 10 before | Expand all | Expand 10 after
3861 // in the previous C++ frames. 3861 // in the previous C++ frames.
3862 Isolate* isolate = thread->isolate(); 3862 Isolate* isolate = thread->isolate();
3863 StackResource::Unwind(thread); 3863 StackResource::Unwind(thread);
3864 3864
3865 // Unwind the C++ stack and continue simulation in the target frame. 3865 // Unwind the C++ stack and continue simulation in the target frame.
3866 set_register(PC, static_cast<int32_t>(pc)); 3866 set_register(PC, static_cast<int32_t>(pc));
3867 set_register(SP, static_cast<int32_t>(sp)); 3867 set_register(SP, static_cast<int32_t>(sp));
3868 set_register(FP, static_cast<int32_t>(fp)); 3868 set_register(FP, static_cast<int32_t>(fp));
3869 set_register(THR, reinterpret_cast<uword>(thread)); 3869 set_register(THR, reinterpret_cast<uword>(thread));
3870 // Set the tag. 3870 // Set the tag.
3871 isolate->set_vm_tag(VMTag::kDartTagId); 3871 thread->set_vm_tag(VMTag::kDartTagId);
3872 // Clear top exit frame. 3872 // Clear top exit frame.
3873 isolate->set_top_exit_frame_info(0); 3873 isolate->set_top_exit_frame_info(0);
3874 3874
3875 ASSERT(raw_exception != Object::null()); 3875 ASSERT(raw_exception != Object::null());
3876 set_register(kExceptionObjectReg, bit_cast<int32_t>(raw_exception)); 3876 set_register(kExceptionObjectReg, bit_cast<int32_t>(raw_exception));
3877 set_register(kStackTraceObjectReg, bit_cast<int32_t>(raw_stacktrace)); 3877 set_register(kStackTraceObjectReg, bit_cast<int32_t>(raw_stacktrace));
3878 buf->Longjmp(); 3878 buf->Longjmp();
3879 } 3879 }
3880 3880
3881 } // namespace dart 3881 } // namespace dart
3882 3882
3883 #endif // defined(USING_SIMULATOR) 3883 #endif // defined(USING_SIMULATOR)
3884 3884
3885 #endif // defined TARGET_ARCH_ARM 3885 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698