Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1387553002: Consistently check if a block can handle pagination strut propagation. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently check if a block can handle pagination strut propagation. https://codereview.chromium.org/1360753002 got it right for inline child layout, but did nothing for block child layout. BUG=329421 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/ce70785c73a2b7cf2b34de0d8439ca31929b4743 Cr-Commit-Position: refs/heads/master@{#352429}

Patch Set 1 #

Total comments: 8

Patch Set 2 : code review #

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-02 11:43:59 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/1387553002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html File third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html (right): https://codereview.chromium.org/1387553002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html#newcode4 third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html:4: <div style="margin-left:50%; line-height:2em;"> Isn't the 50% fragile with ...
5 years, 2 months ago (2015-10-05 17:33:05 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1387553002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html File third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html (right): https://codereview.chromium.org/1387553002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html#newcode4 third_party/WebKit/LayoutTests/fast/multicol/table-caption-with-block-expected.html:4: <div style="margin-left:50%; line-height:2em;"> On 2015/10/05 17:33:05, Julien Chaffraix - ...
5 years, 2 months ago (2015-10-05 19:51:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387553002/20001
5 years, 2 months ago (2015-10-05 19:54:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 21:17:17 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 21:18:11 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce70785c73a2b7cf2b34de0d8439ca31929b4743
Cr-Commit-Position: refs/heads/master@{#352429}

Powered by Google App Engine
This is Rietveld 408576698