Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1387543002: Revert of [Interpreter] Add CallRuntime support to the interpreter. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Add CallRuntime support to the interpreter. (patchset #6 id:180001 of https://codereview.chromium.org/1362383002/ ) Reason for revert: Broke Arm64 bot (CEntry stub is trying to pop arguments off stack when argv_in_reg, so I need to fix this). Original issue's description: > [Interpreter] Add CallRuntime support to the interpreter. > > Adds support for calling runtime functions from the interpreter. Adds the > CallRuntime bytecode which takes a Runtime::FunctionId of the function to call > and the arguments in sequential registers. Adds a InterpreterCEntry builtin > to enable the interpreter to enter C++ code based on the functionId. > > Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall > and groups all the interpreter builtins together. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/40e8424b744f8b6e3e1d93e20f23487419911dfc > Cr-Commit-Position: refs/heads/master@{#31064} TBR=bmeurer@chromium.org,oth@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/90f69d1610c5c2bae3ddad750321c46cd70df639 Cr-Commit-Position: refs/heads/master@{#31066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -737 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +29 lines, -29 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/assembler.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/builtins.h View 5 chunks +8 lines, -8 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M src/code-stubs.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/interpreter-assembler.cc View 2 chunks +4 lines, -31 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +35 lines, -35 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M src/interface-descriptors.h View 3 chunks +6 lines, -15 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 3 chunks +2 lines, -12 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 11 chunks +11 lines, -27 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -24 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +29 lines, -29 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +29 lines, -29 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +21 lines, -35 lines 0 comments Download
M src/runtime/runtime.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +35 lines, -35 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 4 chunks +40 lines, -115 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 3 chunks +2 lines, -29 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Created Revert of [Interpreter] Add CallRuntime support to the interpreter.
5 years, 2 months ago (2015-10-02 09:20:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387543002/1
5 years, 2 months ago (2015-10-02 09:20:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 09:21:51 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 09:22:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90f69d1610c5c2bae3ddad750321c46cd70df639
Cr-Commit-Position: refs/heads/master@{#31066}

Powered by Google App Engine
This is Rietveld 408576698