Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1387473002: Switch HTML5 Fullscreen Over to AppKit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add check for 10.10+ Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
7 7
8 // A class acting as the Objective-C controller for the Browser 8 // A class acting as the Objective-C controller for the Browser
9 // object. Handles interactions between Cocoa and the cross-platform 9 // object. Handles interactions between Cocoa and the cross-platform
10 // code. Each window has a single toolbar and, by virtue of being a 10 // code. Each window has a single toolbar and, by virtue of being a
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // visible (in presentation mode), e.g., because of where the mouse is or 165 // visible (in presentation mode), e.g., because of where the mouse is or
166 // where keyboard focus is. Whenever an object requires bar visibility, it has 166 // where keyboard focus is. Whenever an object requires bar visibility, it has
167 // itself added to |barVisibilityLocks_|. When it no longer requires bar 167 // itself added to |barVisibilityLocks_|. When it no longer requires bar
168 // visibility, it has itself removed. 168 // visibility, it has itself removed.
169 base::scoped_nsobject<NSMutableSet> barVisibilityLocks_; 169 base::scoped_nsobject<NSMutableSet> barVisibilityLocks_;
170 170
171 // Bar visibility locks and releases only result (when appropriate) in changes 171 // Bar visibility locks and releases only result (when appropriate) in changes
172 // in visible state when the following is |YES|. 172 // in visible state when the following is |YES|.
173 BOOL barVisibilityUpdatesEnabled_; 173 BOOL barVisibilityUpdatesEnabled_;
174 174
175 // If this ivar is set to YES, layoutSubviews calls will be ignored. This is
176 // used in fullscreen transition to prevent spurious resize messages from
177 // being sent to the renderer, which causes the transition to be janky.
178 BOOL blockLayoutSubviews_;
179
175 // When going fullscreen for a tab, we need to store the URL and the 180 // When going fullscreen for a tab, we need to store the URL and the
176 // fullscreen type, since we can't show the bubble until 181 // fullscreen type, since we can't show the bubble until
177 // -windowDidEnterFullScreen: gets called. 182 // -windowDidEnterFullScreen: gets called.
178 GURL fullscreenUrl_; 183 GURL fullscreenUrl_;
179 ExclusiveAccessBubbleType exclusiveAccessBubbleType_; 184 ExclusiveAccessBubbleType exclusiveAccessBubbleType_;
180 185
181 // The Extension Command Registry used to determine which keyboard events to 186 // The Extension Command Registry used to determine which keyboard events to
182 // handle. 187 // handle.
183 scoped_ptr<ExtensionKeybindingRegistryCocoa> extension_keybinding_registry_; 188 scoped_ptr<ExtensionKeybindingRegistryCocoa> extension_keybinding_registry_;
184 } 189 }
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 - (ExclusiveAccessBubbleWindowController*)exclusiveAccessBubbleWindowController; 611 - (ExclusiveAccessBubbleWindowController*)exclusiveAccessBubbleWindowController;
607 612
608 // Gets the rect, in window base coordinates, that the omnibox popup should be 613 // Gets the rect, in window base coordinates, that the omnibox popup should be
609 // positioned relative to. 614 // positioned relative to.
610 - (NSRect)omniboxPopupAnchorRect; 615 - (NSRect)omniboxPopupAnchorRect;
611 616
612 @end // @interface BrowserWindowController (TestingAPI) 617 @end // @interface BrowserWindowController (TestingAPI)
613 618
614 619
615 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_ 620 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698