Switch HTML5 Fullscreen Over to AppKit

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 
 #include "base/command_line.h"
@@ skipping 403 matching lines @@
     // on the window bounds to determine whether to show buttons or not.
     if ([self hasToolbar])  // Do not create the buttons in popups.
       [toolbarController_ createBrowserActionButtons];
 
     extension_keybinding_registry_.reset(
         new ExtensionKeybindingRegistryCocoa(browser_->profile(),
             [self window],
             extensions::ExtensionKeybindingRegistry::ALL_EXTENSIONS,
             windowShim_.get()));
 
+    blockLayoutSubviews_ = NO;
+
     // We are done initializing now.
     initializing_ = NO;
   }
   return self;
 }
 
 - (void)dealloc {
   browser_->tab_strip_model()->CloseAllTabs();
 
   // Explicitly release |presentationModeController_| here, as it may call back
@@ skipping 1525 matching lines @@
     [self enterBrowserFullscreenWithToolbar:NO];
   } else {
     [self enterImmersiveFullscreen];
     DCHECK(!url.is_empty());
     [self updateFullscreenExitBubbleURL:url bubbleType:bubbleType];
   }
 }
 
 - (void)enterWebContentFullscreenForURL:(const GURL&)url
                              bubbleType:(ExclusiveAccessBubbleType)bubbleType {
-  [self enterImmersiveFullscreen];
+  if (chrome::mac::SupportsSystemFullscreen() && base::mac::IsOSLionOrLater())

[Robert Sesek, 2015/10/08 15:21:22]

Is the condition after && necessary?

[spqchan, 2015/10/08 16:54:28]

It's not. I removed it

+    [self enterAppKitFullscreen];
+  else
+    [self enterImmersiveFullscreen];
+
   if (!url.is_empty())
     [self updateFullscreenExitBubbleURL:url bubbleType:bubbleType];
 }
 
 - (void)exitAnyFullscreen {
   // TODO(erikchen): Fullscreen modes should stack. Should be able to exit
   // Immersive Fullscreen and still be in AppKit Fullscreen.
   if ([self isInAppKitFullscreen])
     [self exitAppKitFullscreen];
   if ([self isInImmersiveFullscreen])
@@ skipping 81 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 @end  // @implementation BrowserWindowController(WindowType)