Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: runtime/vm/service.cc

Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 1dc403b15ffc2cfc67d5c998bb0dd50447365932..3d28748bc6a606c3c24e39795101eb1d8932dd8d 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2942,10 +2942,7 @@ static bool GetVM(Isolate* isolate, JSONStream* js) {
jsobj.AddProperty("targetCPU", CPU::Id());
jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());
jsobj.AddProperty("version", Version::String());
- // Send pid as a string because it allows us to avoid any issues with
- // pids > 53-bits (when consumed by JavaScript).
- // TODO(johnmccutchan): Codify how integers are sent across the service.
- jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId());
+ jsobj.AddProperty("pid", OS::ProcessId());
jsobj.AddProperty("_assertsEnabled", isolate->flags().asserts());
jsobj.AddProperty("_typeChecksEnabled", isolate->flags().type_checks());
int64_t start_time_millis = (Dart::vm_isolate()->start_time() /

Powered by Google App Engine
This is Rietveld 408576698