Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 604a12c4a252905db9460e58ff5115471527538e..ba2ddc9e691318cef364d48427981de157dd8fc1 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -637,7 +637,7 @@ abstract class VM extends ServiceObjectOwner {
@observable int architectureBits;
@observable bool assertsEnabled = false;
@observable bool typeChecksEnabled = false;
- @observable String pid = '';
+ @observable int pid = 0;
@observable DateTime startTime;
@observable DateTime refreshTime;
@observable Duration get upTime =>
@@ -877,7 +877,7 @@ abstract class VM extends ServiceObjectOwner {
version = map['version'];
targetCPU = map['targetCPU'];
architectureBits = map['architectureBits'];
- var startTimeMillis = map['startTime'].toInt();
+ int startTimeMillis = map['startTime'];
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis);
refreshTime = new DateTime.now();
notifyPropertyChange(#upTime, 0, 1);
@@ -1345,7 +1345,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
entry = map['entry'];
}
var savedStartTime = startTime;
- var startTimeInMillis = map['startTime'].toInt();
+ int startTimeInMillis = map['startTime'];
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeInMillis);
notifyPropertyChange(#upTime, 0, 1);
var countersMap = map['_tagCounters'];
@@ -1879,7 +1879,7 @@ class ServiceEvent extends ServiceObject {
_upgradeCollection(map, owner);
assert(map['isolate'] == null || owner == map['isolate']);
timestamp =
- new DateTime.fromMillisecondsSinceEpoch(map['timestamp'].toInt());
+ new DateTime.fromMillisecondsSinceEpoch(map['timestamp']);
kind = map['kind'];
notifyPropertyChange(#isPauseEvent, 0, 1);
name = 'ServiceEvent $kind';
@@ -1934,7 +1934,7 @@ class ServiceEvent extends ServiceObject {
if (map['logRecord'] != null) {
logRecord = map['logRecord'];
logRecord['time'] =
- new DateTime.fromMillisecondsSinceEpoch(logRecord['time'].toInt());
+ new DateTime.fromMillisecondsSinceEpoch(logRecord['time']);
logRecord['level'] = _findLogLevel(logRecord['level']);
}
}
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_vm_rpc_test.dart » ('j') | runtime/vm/service/service.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698