Add support for calling Cortana URI scheme on Windows

Add support for calling the Cortana URI scheme on Windows. This will allow websites to integrate with Cortana, and allow the integrated Windows help experience to have parity with other major browsers.

BUG=546084

[mike.schechter, 2015-10-12 20:25:13]

mike.schechter@gmail.com changed reviewers:
+ gab@chromium.org, grt@chromium.org

[gab, 2015-10-14 15:41:40]

gab@chromium.org changed reviewers:
+ benwells@chromium.org

[gab, 2015-10-14 15:41:41]

That looks okay, but I think Ben is the expert in protocols and I'll defer to
him.

[gab, 2015-10-14 15:47:35]

On 2015/10/14 15:41:41, gab wrote:
> That looks okay, but I think Ben is the expert in protocols and I'll defer to
> him.

Also, please file a bug @ crbug.com and add its ID to the description of this
CL.

[jschuh, 2015-10-14 17:24:33]

The bug will need to include some documentation on the scheme and exactly what
it exposes. Because anything in allowed_schemes is going to be an increase in
web-facing attack surface, so we need to know exactly what that is.

[mike.schechter, 2015-10-14 22:52:05]

On 2015/10/14 17:24:33, jschuh (very slow) wrote:
> The bug will need to include some documentation on the scheme and exactly what
> it exposes. Because anything in allowed_schemes is going to be an increase in
> web-facing attack surface, so we need to know exactly what that is.

Thanks - pulling this together and will file it shortly

[grt (UTC plus 2), 2015-10-14 23:55:15]

On 2015/10/14 22:52:05, mike.schechter wrote:
> On 2015/10/14 17:24:33, jschuh (very slow) wrote:
> > The bug will need to include some documentation on the scheme and exactly
what
> > it exposes. Because anything in allowed_schemes is going to be an increase
in
> > web-facing attack surface, so we need to know exactly what that is.
> 
> Thanks - pulling this together and will file it shortly

Sounds good. Please open an issue on crbug.com and put the info there, then
update the description of this code review to reference it (e.g., BUG=8675309).

[benwells, 2015-10-19 23:48:12]

On 2015/10/14 23:55:15, grt wrote:
> On 2015/10/14 22:52:05, mike.schechter wrote:
> > On 2015/10/14 17:24:33, jschuh (very slow) wrote:
> > > The bug will need to include some documentation on the scheme and exactly
> what
> > > it exposes. Because anything in allowed_schemes is going to be an increase
> in
> > > web-facing attack surface, so we need to know exactly what that is.
> > 
> > Thanks - pulling this together and will file it shortly
> 
> Sounds good. Please open an issue on http://crbug.com and put the info there,
then
> update the description of this code review to reference it (e.g.,
BUG=8675309).

Is anything happening with this?

[mike.schechter, 2015-10-20 00:04:29]

I still owe the bug with the details - I'm waiting on details from one
person who is on vacation, but is back tomorrow (10/19). I expect to open
the bug and update this CR then. Sorry for the delay.

On Mon, Oct 19, 2015 at 4:48 PM, <benwells@chromium.org> wrote:

> On 2015/10/14 23:55:15, grt wrote:
>
>> On 2015/10/14 22:52:05, mike.schechter wrote:
>> > On 2015/10/14 17:24:33, jschuh (very slow) wrote:
>> > > The bug will need to include some documentation on the scheme and
>> exactly
>> what
>> > > it exposes. Because anything in allowed_schemes is going to be an
>> increase
>> in
>> > > web-facing attack surface, so we need to know exactly what that is.
>> >
>> > Thanks - pulling this together and will file it shortly
>>
>
> Sounds good. Please open an issue on http://crbug.com and put the info
>> there,
>>
> then
>
>> update the description of this code review to reference it (e.g.,
>>
> BUG=8675309).
>
> Is anything happening with this?
>
> https://codereview.chromium.org/1387403003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[benwells, 2015-10-20 00:24:01]

On 2015/10/20 00:04:29, mike.schechter wrote:
> I still owe the bug with the details - I'm waiting on details from one
> person who is on vacation, but is back tomorrow (10/19). I expect to open
> the bug and update this CR then. Sorry for the delay.

ok cool, no problem.

> 
> On Mon, Oct 19, 2015 at 4:48 PM, <mailto:benwells@chromium.org> wrote:
> 
> > On 2015/10/14 23:55:15, grt wrote:
> >
> >> On 2015/10/14 22:52:05, mike.schechter wrote:
> >> > On 2015/10/14 17:24:33, jschuh (very slow) wrote:
> >> > > The bug will need to include some documentation on the scheme and
> >> exactly
> >> what
> >> > > it exposes. Because anything in allowed_schemes is going to be an
> >> increase
> >> in
> >> > > web-facing attack surface, so we need to know exactly what that is.
> >> >
> >> > Thanks - pulling this together and will file it shortly
> >>
> >
> > Sounds good. Please open an issue on http://crbug.com and put the info
> >> there,
> >>
> > then
> >
> >> update the description of this code review to reference it (e.g.,
> >>
> > BUG=8675309).
> >
> > Is anything happening with this?
> >
> > https://codereview.chromium.org/1387403003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[mike.schechter, 2015-10-21 17:56:49]

Description was changed from

==========
Add support for calling Cortana protocol on Windows. This will allow websites to
integrate with Cortana, and allow the integrated Windows help experience to have
parity with other major browsers.

BUG=
==========

to

==========
Add support for calling the Cortana URI scheme on Windows. This will allow
websites to integrate with Cortana, and allow the integrated Windows help
experience to have parity with other major browsers.

BUG=546084
==========

[mike.schechter, 2015-10-21 17:57:30]

On 2015/10/20 00:24:01, benwells wrote:
> On 2015/10/20 00:04:29, mike.schechter wrote:
> > I still owe the bug with the details - I'm waiting on details from one
> > person who is on vacation, but is back tomorrow (10/19). I expect to open
> > the bug and update this CR then. Sorry for the delay.
> 
> ok cool, no problem.
> 
> > 
> > On Mon, Oct 19, 2015 at 4:48 PM, <mailto:benwells@chromium.org> wrote:
> > 
> > > On 2015/10/14 23:55:15, grt wrote:
> > >
> > >> On 2015/10/14 22:52:05, mike.schechter wrote:
> > >> > On 2015/10/14 17:24:33, jschuh (very slow) wrote:
> > >> > > The bug will need to include some documentation on the scheme and
> > >> exactly
> > >> what
> > >> > > it exposes. Because anything in allowed_schemes is going to be an
> > >> increase
> > >> in
> > >> > > web-facing attack surface, so we need to know exactly what that is.
> > >> >
> > >> > Thanks - pulling this together and will file it shortly
> > >>
> > >
> > > Sounds good. Please open an issue on http://crbug.com and put the info
> > >> there,
> > >>
> > > then
> > >
> > >> update the description of this code review to reference it (e.g.,
> > >>
> > > BUG=8675309).
> > >
> > > Is anything happening with this?
> > >
> > > https://codereview.chromium.org/1387403003/
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

I've filed a bug at https://code.google.com/p/chromium/issues/detail?id=546084
and linked it in the issue description.

[mike.schechter, 2015-10-23 16:54:06]

Please let me know if you have any additional questions - thanks!

On Wed, Oct 21, 2015 at 10:57 AM, <mike.schechter@gmail.com> wrote:

> On 2015/10/20 00:24:01, benwells wrote:
>
>> On 2015/10/20 00:04:29, mike.schechter wrote:
>> > I still owe the bug with the details - I'm waiting on details from one
>> > person who is on vacation, but is back tomorrow (10/19). I expect to
>> open
>> > the bug and update this CR then. Sorry for the delay.
>>
>
> ok cool, no problem.
>>
>
> >
>> > On Mon, Oct 19, 2015 at 4:48 PM, <mailto:benwells@chromium.org> wrote:
>> >
>> > > On 2015/10/14 23:55:15, grt wrote:
>> > >
>> > >> On 2015/10/14 22:52:05, mike.schechter wrote:
>> > >> > On 2015/10/14 17:24:33, jschuh (very slow) wrote:
>> > >> > > The bug will need to include some documentation on the scheme and
>> > >> exactly
>> > >> what
>> > >> > > it exposes. Because anything in allowed_schemes is going to be an
>> > >> increase
>> > >> in
>> > >> > > web-facing attack surface, so we need to know exactly what that
>> is.
>> > >> >
>> > >> > Thanks - pulling this together and will file it shortly
>> > >>
>> > >
>> > > Sounds good. Please open an issue on http://crbug.com and put the
>> info
>> > >> there,
>> > >>
>> > > then
>> > >
>> > >> update the description of this code review to reference it (e.g.,
>> > >>
>> > > BUG=8675309).
>> > >
>> > > Is anything happening with this?
>> > >
>> > > https://codereview.chromium.org/1387403003/
>> > >
>> >
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> email
>> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> I've filed a bug at
> https://code.google.com/p/chromium/issues/detail?id=546084
> and linked it in the issue description.
>
> https://codereview.chromium.org/1387403003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[benwells, 2015-10-26 07:04:42]

lgtm. You'll need an owner to review as well, and you should also wait for
jschuh to give an lg too.

[jschuh, 2015-10-28 14:45:17]

I added a comment in the bug to explain why I'm giving this a not lgtm. Since
this is a non-standard, open-ended protocol handler it really needs to be
treated like other non-standard protocol handlers and we need to allow the user
to approve or deny it (which should have been fixed prior to adding
ms-windows-store). I'm happy to approve a CL that exposes these as other
non-standard protocol handlers are exposed.

[gab, 2015-11-12 13:40:23]

On 2015/10/28 14:45:17, jschuh (very slow) wrote:
> I added a comment in the bug to explain why I'm giving this a not lgtm. Since
> this is a non-standard, open-ended protocol handler it really needs to be
> treated like other non-standard protocol handlers and we need to allow the
user
> to approve or deny it (which should have been fixed prior to adding
> ms-windows-store). I'm happy to approve a CL that exposes these as other
> non-standard protocol handlers are exposed.

Thanks jschuch, will close this CL.

[mike.schechter, 2015-11-18 18:46:57]

Belated thanks for the helpful info here and in the bug. We're looking into
alternative approaches to get this working.

On Thu, Nov 12, 2015 at 5:40 AM, <gab@chromium.org> wrote:

> On 2015/10/28 14:45:17, jschuh (very slow) wrote:
>
>> I added a comment in the bug to explain why I'm giving this a not lgtm.
>> Since
>> this is a non-standard, open-ended protocol handler it really needs to be
>> treated like other non-standard protocol handlers and we need to allow the
>>
> user
>
>> to approve or deny it (which should have been fixed prior to adding
>> ms-windows-store). I'm happy to approve a CL that exposes these as other
>> non-standard protocol handlers are exposed.
>>
>
> Thanks jschuch, will close this CL.
>
> https://codereview.chromium.org/1387403003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.