Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 13874010: Merge JumpToErrorHandler and JumpToExceptionHandler stubs on all architectures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 21683)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1879,7 +1879,7 @@
}
-// Jump to the exception handler.
+// Jump to the exception or error handler.
// TOS + 0: return address
// TOS + 1: program_counter
// TOS + 2: stack_pointer
@@ -1899,23 +1899,6 @@
}
-// Jump to the error handler.
-// TOS + 0: return address
-// TOS + 1: program_counter
-// TOS + 2: stack_pointer
-// TOS + 3: frame_pointer
-// TOS + 4: error object
-// No Result.
-void StubCode::GenerateJumpToErrorHandlerStub(Assembler* assembler) {
- ASSERT(kExceptionObjectReg == EAX);
- __ movl(EAX, Address(ESP, 4 * kWordSize)); // Load error object.
- __ movl(EBP, Address(ESP, 3 * kWordSize)); // Load target frame_pointer.
- __ movl(EBX, Address(ESP, 1 * kWordSize)); // Load target PC into EBX.
- __ movl(ESP, Address(ESP, 2 * kWordSize)); // Load target stack_pointer.
- __ jmp(EBX); // Jump to the exception handler code.
-}
-
-
// Implements equality operator when one of the arguments is null
// (identity check) and updates ICData if necessary.
// TOS + 0: return address
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698