Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1387383005: Eagerly extract stack limit from Isolate in InitializeAstVisitor() (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eagerly extract stack limit from Isolate in InitializeAstVisitor() Previously, any AstVisitor subclasses which wanted to make use of the shared stack overflow checking code needed to depend on Isolate. With this patch, it will be easy to create a second InitializeAstVisitor overload taking a stack_limit directly, for use in code that has no Isolate available (such as code running in the parser). AstVisitor subclasses which depended upon the isolate() accessor have been fixed to either have their own isolate_ member or get it from somewhere else convenient. Committed: https://crrev.com/d317145d05f25232f8c45f5b8ed98e2df6610afb Cr-Commit-Position: refs/heads/master@{#31260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M src/ast.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/ast-numbering.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/typing.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/typing.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 2 months ago (2015-10-14 12:21:47 UTC) #2
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-10-14 12:36:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387383005/1
5 years, 2 months ago (2015-10-14 12:43:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 13:04:53 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 13:05:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d317145d05f25232f8c45f5b8ed98e2df6610afb
Cr-Commit-Position: refs/heads/master@{#31260}

Powered by Google App Engine
This is Rietveld 408576698