Remove code that analyzes tos values from tickprocessor

Remove code that analyzes tos values from tickprocessor

Assuming that the value on top of stack is return address for a frameless invocation is error-prone. Corresponding logic was removed from profile-generator.cc in r14205 (see https://code.google.com/p/v8/source/diff?spec=svn14205&r=14205&format=side&path=/branches/bleeding_edge/src/profile-generator.cc) and now it is time to remove it from the tick processor.

Since the tos is not used anymore by profiler it is also removed from TickSample.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14252

[loislo, 2013-04-12 10:49:26]

https://codereview.chromium.org/13873009/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (left):

https://codereview.chromium.org/13873009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:67: sample->tos = frame1;
is external_callback initialized properly?

https://codereview.chromium.org/13873009/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):

https://codereview.chromium.org/13873009/diff/1/tools/tickprocessor.js#newcod...
tools/tickprocessor.js:393: this.profile_.recordTick(this.processStack(pc,
external_callback, stack));
old version passed PC and 0 if we have external callback.
new version passes 0 and external callback in that case.

[yurys, 2013-04-12 10:54:50]

https://codereview.chromium.org/13873009/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (left):

https://codereview.chromium.org/13873009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:67: sample->tos = frame1;
On 2013/04/12 10:49:26, loislo wrote:
> is external_callback initialized properly?
Yes, ProfilerEventsProcessor::TickSampleEvent calls placement new for the
returned sample so this code is OK.

https://codereview.chromium.org/13873009/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):

https://codereview.chromium.org/13873009/diff/1/tools/tickprocessor.js#newcod...
tools/tickprocessor.js:393: this.profile_.recordTick(this.processStack(pc,
external_callback, stack));
On 2013/04/12 10:49:26, loislo wrote:
> old version passed PC and 0 if we have external callback.
> new version passes 0 and external callback in that case.

This is fine. It basically reverts this change:
https://codereview.chromium.org/6708056/diff/1/tools/tickprocessor.js?context...

[loislo, 2013-04-12 10:59:54]

lgtm

[Jakob Kummerow, 2013-04-12 11:02:34]

lgtm

[yurys, 2013-04-12 11:20:37]

Committed patchset #1 manually as r14252.