Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1387293002: TimeClip converts -0 to +0, following ES2015 spec (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TimeClip converts -0 to +0, following ES2015 spec In ES2015, section 20.3.1.15, TimeClip (an internal algorihtm which is called when normalizing Date representations) is specified to add 0 to its result, which converts -0 into +0. This patch adds that conversion to the Date code. It is verified by the test262 test built-ins/Date/TimeClip_negative_zero R=adamk Committed: https://crrev.com/eeaf80cd86513c145b8c9dd195dde3912abf4585 Cr-Commit-Position: refs/heads/master@{#31159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387293002/1
5 years, 2 months ago (2015-10-07 01:24:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 01:46:38 UTC) #4
Dan Ehrenberg
5 years, 2 months ago (2015-10-07 17:01:12 UTC) #5
adamk
lgtm
5 years, 2 months ago (2015-10-07 18:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387293002/1
5 years, 2 months ago (2015-10-07 18:14:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 18:17:52 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 18:19:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeaf80cd86513c145b8c9dd195dde3912abf4585
Cr-Commit-Position: refs/heads/master@{#31159}

Powered by Google App Engine
This is Rietveld 408576698