cc: Remove redundant is_overlay arguments

cc/output/overlay_strategy_single_on_top.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/output/overlay_strategy_single_on_top.h"
 
 #include "cc/base/math_util.h"
 #include "cc/output/overlay_candidate_validator.h"
 #include "cc/quads/draw_quad.h"
 
 namespace cc {
 
 OverlayStrategySingleOnTop::OverlayStrategySingleOnTop(
     OverlayCandidateValidator* capability_checker)
     : capability_checker_(capability_checker) {
   DCHECK(capability_checker);
 }
 
 OverlayStrategySingleOnTop::~OverlayStrategySingleOnTop() {}
 
-bool OverlayStrategySingleOnTop::Attempt(RenderPassList* render_passes,
+bool OverlayStrategySingleOnTop::Attempt(ResourceProvider* resource_provider,
+                                         RenderPassList* render_passes,
                                          OverlayCandidateList* candidate_list) {
-  QuadList& quad_list = render_passes->back()->quad_list;
-  for (auto it = quad_list.begin(); it != quad_list.end(); ++it) {
+  QuadList* quad_list = &render_passes->back()->quad_list;
+  for (auto it = quad_list->begin(); it != quad_list->end(); ++it) {
     OverlayCandidate candidate;
-    if (OverlayCandidate::FromDrawQuad(*it, &candidate) &&
+    if (OverlayCandidate::FromDrawQuad(resource_provider, *it, &candidate) &&
         TryOverlay(quad_list, candidate_list, candidate, it)) {
       return true;
     }
   }
 
   return false;
 }
 
 bool OverlayStrategySingleOnTop::TryOverlay(
-    QuadList& quad_list,
+    QuadList* quad_list,
     OverlayCandidateList* candidate_list,
     const OverlayCandidate& candidate,
     QuadList::Iterator candidate_iterator) {
   // Check that no prior quads overlap it.
-  for (auto overlap_iter = quad_list.cbegin();
-       overlap_iter != candidate_iterator; ++overlap_iter) {
+  for (auto overlap_iter : *quad_list) {

[ccameron, 2015/10/08 05:22:18]

Hmm, this broke things. I'll put this in the category of "types improve
readability, why again is C++ trying to hide them?"

[dcheng, 2015/10/08 05:44:15]

I'm not sure why this broke things, but note that:

for (auto overlap_iter : *quads_list) {

is copying a DrawQuad. Usually you want:

for (const auto& quad : *quads_list) {

or:

for (auto& quad : *quads_list) {

     gfx::RectF overlap_rect = MathUtil::MapClippedRect(
         overlap_iter->shared_quad_state->quad_to_target_transform,
         gfx::RectF(overlap_iter->rect));
     if (candidate.display_rect.Intersects(overlap_rect) &&
-        !OverlayCandidate::IsInvisibleQuad(*overlap_iter))
+        !OverlayCandidate::IsInvisibleQuad(overlap_iter))
       return false;
   }
 
   // Add the overlay.
   OverlayCandidateList new_candidate_list = *candidate_list;
   new_candidate_list.push_back(candidate);
   new_candidate_list.back().plane_z_order = 1;
 
   // Check for support.
   capability_checker_->CheckOverlaySupport(&new_candidate_list);
 
   // If the candidate can be handled by an overlay, create a pass for it.
   if (new_candidate_list.back().overlay_handled) {
-    quad_list.EraseAndInvalidateAllPointers(candidate_iterator);
+    quad_list->EraseAndInvalidateAllPointers(candidate_iterator);
     candidate_list->swap(new_candidate_list);
     return true;
   }
 
   return false;
 }
 
 }  // namespace cc