Issue 1387273002: Fix Crypto.getRandomValues to modify its argument, fix tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1387273002: Fix Crypto.getRandomValues to modify its argument, fix tests (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:
vsm, terry

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix Crypto.getRandomValues to modify its argument, fix tests BUG= Committed: https://github.com/dart-lang/sdk/commit/9ad57e7aa316c46dc153f9d6f3e2c8ea8a457ab2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -12 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+9 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+17 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	2 chunks	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_Crypto.darttemplate	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Alan Knight

Corresponding Dart changes from the fix for getRandomValues

5 years, 2 months ago (2015-10-07 00:34:55 UTC) #2

Alan Knight

5 years, 2 months ago (2015-10-07 16:11:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9ad57e7aa316c46dc153f9d6f3e2c8ea8a457ab2 (presubmit successful).