Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: components/sync_driver/revisit/offset_tab_matcher.h

Issue 1387253004: [Sync] Creating sync_sessions component, moving revisit logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing test_support target. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/revisit/offset_tab_matcher.h
diff --git a/components/sync_driver/revisit/offset_tab_matcher.h b/components/sync_driver/revisit/offset_tab_matcher.h
deleted file mode 100644
index 720527d97d8ee61fc26903baef99dac0cd5b3d33..0000000000000000000000000000000000000000
--- a/components/sync_driver/revisit/offset_tab_matcher.h
+++ /dev/null
@@ -1,40 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_SYNC_DRIVER_OFFSET_TAB_MATCHER_H_
-#define COMPONENTS_SYNC_DRIVER_OFFSET_TAB_MATCHER_H_
-
-#include "components/sessions/core/session_types.h"
-#include "components/sync_driver/revisit/page_equality.h"
-#include "components/sync_driver/revisit/page_visit_observer.h"
-
-namespace sync_driver {
-
-// This class looks for tabs that have matching pages that are not the current
-// navigation entry. This corresponds to the pages you would arrive at if you
-// pressed the forward/backwards buttons. The goal is to emit metrics for the
-// most recent/current entry. So to break ties of multiple entries that match,
-// first the timestamp on the tab is used, followed by the index of the entry.
-// This isn't necessarily perfect at determining the most recent, but it should
-// be a reasonable enough approximation.
-class OffsetTabMatcher {
- public:
- explicit OffsetTabMatcher(const PageEquality& page_equality);
- void Check(const sessions::SessionTab* tab);
- void Emit(const PageVisitObserver::TransitionType transition);
-
- private:
- int Clamp(int input, int lower, int upper);
-
- const PageEquality page_equality_;
- const sessions::SessionTab* best_tab_ = nullptr;
- // Invalid while best_tab_ is nullptr.
- int best_offset_ = 0;
-
- DISALLOW_COPY_AND_ASSIGN(OffsetTabMatcher);
-};
-
-} // namespace sync_driver
-
-#endif // COMPONENTS_SYNC_DRIVER_OFFSET_TAB_MATCHER_H_
« no previous file with comments | « components/sync_driver/revisit/current_tab_matcher_unittest.cc ('k') | components/sync_driver/revisit/offset_tab_matcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698