Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/sync/sessions/page_revisit_broadcaster_unittest.cc

Issue 1387253004: [Sync] Creating sync_sessions component, moving revisit logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing test_support target. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/sync/sessions/page_revisit_broadcaster.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sessions/page_revisit_broadcaster.h" 5 #include "chrome/browser/sync/sessions/page_revisit_broadcaster.h"
6 6
7 #include "components/sync_driver/revisit/page_visit_observer.h" 7 #include "components/sync_sessions/revisit/page_visit_observer.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/base/page_transition_types.h" 9 #include "ui/base/page_transition_types.h"
10 10
11 using sync_sessions::PageVisitObserver;
12
11 namespace browser_sync { 13 namespace browser_sync {
12 14
13 class PageRevisitBroadcasterTest : public ::testing::Test { 15 class PageRevisitBroadcasterTest : public ::testing::Test {
14 protected: 16 protected:
15 sync_driver::PageVisitObserver::TransitionType Convert( 17 PageVisitObserver::TransitionType Convert(
16 const ui::PageTransition conversionInput) { 18 const ui::PageTransition conversionInput) {
17 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput); 19 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput);
18 } 20 }
19 21
20 void Check(const sync_driver::PageVisitObserver::TransitionType expected, 22 void Check(const PageVisitObserver::TransitionType expected,
21 const ui::PageTransition conversionInput) { 23 const ui::PageTransition conversionInput) {
22 EXPECT_EQ(expected, Convert(conversionInput)); 24 EXPECT_EQ(expected, Convert(conversionInput));
23 } 25 }
24 26
25 void Check(const sync_driver::PageVisitObserver::TransitionType expected, 27 void Check(const PageVisitObserver::TransitionType expected,
26 const int32 conversionInput) { 28 const int32 conversionInput) {
27 Check(expected, ui::PageTransitionFromInt(conversionInput)); 29 Check(expected, ui::PageTransitionFromInt(conversionInput));
28 } 30 }
29 }; 31 };
30 32
31 TEST_F(PageRevisitBroadcasterTest, ConvertPageInteraction) { 33 TEST_F(PageRevisitBroadcasterTest, ConvertPageInteraction) {
32 Check(sync_driver::PageVisitObserver::kTransitionPage, 34 Check(PageVisitObserver::kTransitionPage, ui::PAGE_TRANSITION_LINK);
33 ui::PAGE_TRANSITION_LINK); 35 Check(PageVisitObserver::kTransitionPage,
34 Check(sync_driver::PageVisitObserver::kTransitionPage,
35 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_BLOCKED); 36 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_BLOCKED);
36 Check(sync_driver::PageVisitObserver::kTransitionPage, 37 Check(PageVisitObserver::kTransitionPage,
37 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FORWARD_BACK); 38 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FORWARD_BACK);
38 // Don't check ui::PAGE_TRANSITION_FROM_ADDRESS_BAR, this is actually a copy 39 // Don't check ui::PAGE_TRANSITION_FROM_ADDRESS_BAR, this is actually a copy
39 // and paste action when combined with ui::PAGE_TRANSITION_LINK. 40 // and paste action when combined with ui::PAGE_TRANSITION_LINK.
40 Check(sync_driver::PageVisitObserver::kTransitionPage, 41 Check(PageVisitObserver::kTransitionPage,
41 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_HOME_PAGE); 42 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_HOME_PAGE);
42 Check(sync_driver::PageVisitObserver::kTransitionPage, 43 Check(PageVisitObserver::kTransitionPage,
43 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FROM_API); 44 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FROM_API);
44 Check(sync_driver::PageVisitObserver::kTransitionPage, 45 Check(PageVisitObserver::kTransitionPage,
45 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CHAIN_START); 46 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CHAIN_START);
46 Check(sync_driver::PageVisitObserver::kTransitionPage, 47 Check(PageVisitObserver::kTransitionPage,
47 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CHAIN_END); 48 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CHAIN_END);
48 Check(sync_driver::PageVisitObserver::kTransitionPage, 49 Check(PageVisitObserver::kTransitionPage,
49 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CLIENT_REDIRECT); 50 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CLIENT_REDIRECT);
50 Check(sync_driver::PageVisitObserver::kTransitionPage, 51 Check(PageVisitObserver::kTransitionPage,
51 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_SERVER_REDIRECT); 52 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_SERVER_REDIRECT);
52 Check(sync_driver::PageVisitObserver::kTransitionPage, 53 Check(PageVisitObserver::kTransitionPage,
53 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_IS_REDIRECT_MASK); 54 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_IS_REDIRECT_MASK);
54 } 55 }
55 56
56 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxURL) { 57 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxURL) {
57 Check(sync_driver::PageVisitObserver::kTransitionOmniboxUrl, 58 Check(PageVisitObserver::kTransitionOmniboxUrl, ui::PAGE_TRANSITION_TYPED);
58 ui::PAGE_TRANSITION_TYPED); 59 Check(PageVisitObserver::kTransitionOmniboxUrl,
59 Check(sync_driver::PageVisitObserver::kTransitionOmniboxUrl,
60 ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR); 60 ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
61 } 61 }
62 62
63 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxDefaultSearch) { 63 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxDefaultSearch) {
64 Check(sync_driver::PageVisitObserver::kTransitionOmniboxDefaultSearch, 64 Check(PageVisitObserver::kTransitionOmniboxDefaultSearch,
65 ui::PAGE_TRANSITION_GENERATED); 65 ui::PAGE_TRANSITION_GENERATED);
66 Check(sync_driver::PageVisitObserver::kTransitionOmniboxDefaultSearch, 66 Check(PageVisitObserver::kTransitionOmniboxDefaultSearch,
67 ui::PAGE_TRANSITION_GENERATED | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR); 67 ui::PAGE_TRANSITION_GENERATED | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
68 } 68 }
69 69
70 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxTemplateSearch) { 70 TEST_F(PageRevisitBroadcasterTest, ConvertOmniboxTemplateSearch) {
71 Check(sync_driver::PageVisitObserver::kTransitionOmniboxTemplateSearch, 71 Check(PageVisitObserver::kTransitionOmniboxTemplateSearch,
72 ui::PAGE_TRANSITION_KEYWORD); 72 ui::PAGE_TRANSITION_KEYWORD);
73 Check(sync_driver::PageVisitObserver::kTransitionOmniboxTemplateSearch, 73 Check(PageVisitObserver::kTransitionOmniboxTemplateSearch,
74 ui::PAGE_TRANSITION_KEYWORD | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR); 74 ui::PAGE_TRANSITION_KEYWORD | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
75 Check(sync_driver::PageVisitObserver::kTransitionOmniboxTemplateSearch, 75 Check(PageVisitObserver::kTransitionOmniboxTemplateSearch,
76 ui::PAGE_TRANSITION_KEYWORD_GENERATED); 76 ui::PAGE_TRANSITION_KEYWORD_GENERATED);
77 Check(sync_driver::PageVisitObserver::kTransitionOmniboxTemplateSearch, 77 Check(PageVisitObserver::kTransitionOmniboxTemplateSearch,
78 ui::PAGE_TRANSITION_KEYWORD_GENERATED | 78 ui::PAGE_TRANSITION_KEYWORD_GENERATED |
79 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR); 79 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
80 } 80 }
81 81
82 TEST_F(PageRevisitBroadcasterTest, ConvertBookmark) { 82 TEST_F(PageRevisitBroadcasterTest, ConvertBookmark) {
83 Check(sync_driver::PageVisitObserver::kTransitionBookmark, 83 Check(PageVisitObserver::kTransitionBookmark,
84 ui::PAGE_TRANSITION_AUTO_BOOKMARK); 84 ui::PAGE_TRANSITION_AUTO_BOOKMARK);
85 } 85 }
86 86
87 TEST_F(PageRevisitBroadcasterTest, ConvertCopyPaste) { 87 TEST_F(PageRevisitBroadcasterTest, ConvertCopyPaste) {
88 Check(sync_driver::PageVisitObserver::kTransitionCopyPaste, 88 Check(PageVisitObserver::kTransitionCopyPaste,
89 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR); 89 ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
90 } 90 }
91 91
92 TEST_F(PageRevisitBroadcasterTest, ConvertForwardBackward) { 92 TEST_F(PageRevisitBroadcasterTest, ConvertForwardBackward) {
93 Check(sync_driver::PageVisitObserver::kTransitionForwardBackward, 93 Check(PageVisitObserver::kTransitionForwardBackward,
94 ui::PAGE_TRANSITION_AUTO_TOPLEVEL | ui::PAGE_TRANSITION_FORWARD_BACK); 94 ui::PAGE_TRANSITION_AUTO_TOPLEVEL | ui::PAGE_TRANSITION_FORWARD_BACK);
95 } 95 }
96 96
97 TEST_F(PageRevisitBroadcasterTest, ConvertRestore) { 97 TEST_F(PageRevisitBroadcasterTest, ConvertRestore) {
98 Check(sync_driver::PageVisitObserver::kTransitionRestore, 98 Check(PageVisitObserver::kTransitionRestore, ui::PAGE_TRANSITION_RELOAD);
99 ui::PAGE_TRANSITION_RELOAD);
100 } 99 }
101 100
102 TEST_F(PageRevisitBroadcasterTest, ConvertUnknown) { 101 TEST_F(PageRevisitBroadcasterTest, ConvertUnknown) {
103 Check(sync_driver::PageVisitObserver::kTransitionUnknown, 102 Check(PageVisitObserver::kTransitionUnknown,
104 ui::PAGE_TRANSITION_AUTO_SUBFRAME); 103 ui::PAGE_TRANSITION_AUTO_SUBFRAME);
105 Check(sync_driver::PageVisitObserver::kTransitionUnknown, 104 Check(PageVisitObserver::kTransitionUnknown,
106 ui::PAGE_TRANSITION_MANUAL_SUBFRAME); 105 ui::PAGE_TRANSITION_MANUAL_SUBFRAME);
107 Check(sync_driver::PageVisitObserver::kTransitionUnknown, 106 Check(PageVisitObserver::kTransitionUnknown,
108 ui::PAGE_TRANSITION_AUTO_TOPLEVEL); 107 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
109 } 108 }
110 109
111 } // namespace browser_sync 110 } // namespace browser_sync
OLDNEW
« no previous file with comments | « chrome/browser/sync/sessions/page_revisit_broadcaster.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698