Issue 1387213002: When applying a gerrit patch, do a checkout before soft resetting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1387213002: When applying a gerrit patch, do a checkout before soft resetting. (Closed)

Created:
5 years, 2 months ago by Geoff Lang

Modified:
5 years, 2 months ago

Reviewers:
hinoka

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

When applying a gerrit patch, do a checkout before soft resetting. The previous method would do a soft reset to the patch which would generate a correct list of differing files but not update the working tree. Instead, checkout the patch so that it is fully applied and then soft reset back to the base revision. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297034

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	scripts/slave/bot_update.py	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387213002/60001

5 years, 2 months ago (2015-10-06 18:00:43 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-06 18:04:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297034

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1387213002: When applying a gerrit patch, do a checkout before soft resetting. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : strip rev-parse output #

Messages