Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 13872022: Expose RequestComplete time to DRT (Closed)

Created:
7 years, 8 months ago by Pan
Modified:
7 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Expose RequestComplete time to DRT Currently loadFinishTime of CachedResource in blink part is always 0 when run layout test case via DRT, while the value is there when run a real browser. The reason is RequestProxy in testshell use a blank TimeTicks as request complete time. This issue affects Resource Timing layout test cases. Contributed by pan.deng@intel.com R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Pan
please have a review :) thanks! Pan
7 years, 8 months ago (2013-04-23 14:00:01 UTC) #1
mmenke
Deferring to other reviewers. I don't feel I'm sufficiently familiar with this code to review ...
7 years, 8 months ago (2013-04-23 14:27:33 UTC) #2
darin (slow to review)
LGTM
7 years, 8 months ago (2013-04-23 19:36:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/13872022/1
7 years, 8 months ago (2013-04-23 19:36:59 UTC) #4
darin (slow to review)
nit: please don't add empty "BUG=" lines to the change description.
7 years, 8 months ago (2013-04-23 19:38:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/13872022/1
7 years, 8 months ago (2013-04-23 19:38:17 UTC) #6
commit-bot: I haz the power
Change committed as 195963
7 years, 8 months ago (2013-04-24 00:33:28 UTC) #7
Pan
7 years, 8 months ago (2013-04-24 00:45:48 UTC) #8
Message was sent while issue was closed.
On 2013/04/23 19:38:03, darin wrote:
> nit: please don't add empty "BUG=" lines to the change description.

thanks for your guide :)

Pan

Powered by Google App Engine
This is Rietveld 408576698