Bluetooth: gather usage metrics

chrome/common/metrics/proto/system_profile.proto

Index: chrome/common/metrics/proto/system_profile.proto
diff --git a/chrome/common/metrics/proto/system_profile.proto b/chrome/common/metrics/proto/system_profile.proto
index 38cbc14b054c6bb008d9f039f0e5b421ebbf502a..377542227eaa80d8295de42c9c7a064f9d9e94ff 100644
--- a/chrome/common/metrics/proto/system_profile.proto
+++ b/chrome/common/metrics/proto/system_profile.proto
@@ -11,7 +11,7 @@ option optimize_for = LITE_RUNTIME;
 
 package metrics;
 
-// Next tag: 14
+// Next tag: 15
 message SystemProfileProto {
   // The time when the client was compiled/linked, in seconds since the epoch.
   optional int64 build_timestamp = 1;
@@ -139,12 +139,12 @@ message SystemProfileProto {
         optional float overall_score = 3;
       }
       optional PerformanceStatistics performance_statistics = 5;
-      
-      // The GL_VENDOR string. An example of a gl_vendor string is 
+
+      // The GL_VENDOR string. An example of a gl_vendor string is
       // "Imagination Technologies". "" if we are not using OpenGL.
       optional string gl_vendor = 6;
-      
-      // The GL_RENDERER string. An example of a gl_renderer string is 
+
+      // The GL_RENDERER string. An example of a gl_renderer string is
       // "PowerVR SGX 540". "" if we are not using OpenGL.
       optional string gl_renderer = 7;
     }
@@ -364,4 +364,52 @@ message SystemProfileProto {
     optional fixed32 group_id = 2;
   }
   repeated FieldTrial field_trial = 9;
+
+  // Information about Bluetooth devices paired with the system.
+  message Bluetooth {
+    // Whether Bluetooth is present on this system.
+    optional bool is_present = 1;
+
+    // Whether Bluetooth is enabled on this system.
+    optional bool is_enabled = 2;
+
+    // Describes a paired device.
+    message PairedDevice {
+      // Assigned class of the device.

[Ilya Sherman, 2013/04/20 04:54:02]

Please document what the class is, i.e. how to interpret this field.

[keybuk, 2013/04/22 19:30:51]

Done.

+      optional uint32 bluetooth_class = 1;
+
+      // Decoded device type.
+      enum Type {
+        DEVICE_UNKNOWN = 0;
+        DEVICE_COMPUTER = 1;
+        DEVICE_PHONE = 2;
+        DEVICE_MODEM = 3;
+        DEVICE_AUDIO = 4;
+        DEVICE_CAR_AUDIO = 5;
+        DEVICE_VIDEO = 6;
+        DEVICE_PERIPHERAL = 7;
+        DEVICE_JOYSTICK = 8;
+        DEVICE_GAMEPAD = 9;
+        DEVICE_KEYBOARD = 10;
+        DEVICE_MOUSE = 11;
+        DEVICE_TABLET = 12;
+        DEVICE_KEYBOARD_MOUSE_COMBO = 13;
+      }
+      optional Type type = 2;
+
+      // Vendor prefix of the Bluetooth address.

[Ilya Sherman, 2013/04/20 04:54:02]

Please document what this string looks like.  Also, is there any chance we could
upload this as a number, or small tuple of numbers, rather than as a string? 
That would help assuage privacy concerns.

Regardless, please make sure to get approval from the privacy and legal teams to
track this data.

[keybuk, 2013/04/22 19:30:51]

Done; encoded as a uint32_t
(I couldn't see a useful way to declare it as just three bytes)
In progress currently (since Jan!)

[Ilya Sherman, 2013/04/23 00:09:43]

Yeah, I'm likewise not aware of any cleaner way to write just three bytes. 
Thanks.
Since we'll actually start uploading the data once this CL lands, it's very
important to get approval from these teams *prior* to landing the code.

[keybuk, 2013/04/23 00:41:41]

Sure - I had a preliminary "no problem" from the privacy review before I even
wrote the code - I'm just parallelizing the final review with the code review
for efficiency's sake - it won't be committed until there's approval from both

+      optional string vendor_prefix = 4;
+
+      // Vendor ID, where available.
+      optional uint32 vendor_id = 5;
+
+      // Product ID, where available.
+      optional uint32 product_id = 6;
+
+      // Device Release Number, where available.
+      optional uint32 bcd_device = 7;
+    }
+    repeated PairedDevice paired_device = 3;
+  }
+  optional Bluetooth bluetooth = 14;

[Ilya Sherman, 2013/04/20 04:54:02]

This tag is actually already being used by the internal copy of the protocol
buffer, and tag 15 is about to be.  You'll want to skip all the way to 16.

Better yet, though, would be to put this under the hardware section of the
protocol buffer (IMO).

[keybuk, 2013/04/22 19:30:51]

Done.

 }