Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1387173003: [SkDebugger] Handle path empty-bounds gracefully (Closed)

Created:
5 years, 2 months ago by f(malita)
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[SkDebugger] Handle path empty-bounds gracefully Paths with empty bounds crash the debugger: mapping their bounds onto the shapshot area gets the canvas into an unhappy state. R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/b0cd8b714629352638f17154cfc05ade03fff8f5

Patch Set 1 #

Patch Set 2 : don't forget to restore #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/utils/debugger/SkDrawCommand.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
f(malita)
5 years, 2 months ago (2015-10-06 13:48:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387173003/20001
5 years, 2 months ago (2015-10-06 13:48:55 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-06 13:48:56 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1387173003/diff/20001/src/utils/debugger/SkDrawCommand.cpp File src/utils/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/1387173003/diff/20001/src/utils/debugger/SkDrawCommand.cpp#newcode101 src/utils/debugger/SkDrawCommand.cpp:101: void render_path(SkCanvas* canvas, const SkPath& path) { Maybe ...
5 years, 2 months ago (2015-10-06 14:12:55 UTC) #5
f(malita)
https://codereview.chromium.org/1387173003/diff/20001/src/utils/debugger/SkDrawCommand.cpp File src/utils/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/1387173003/diff/20001/src/utils/debugger/SkDrawCommand.cpp#newcode101 src/utils/debugger/SkDrawCommand.cpp:101: void render_path(SkCanvas* canvas, const SkPath& path) { On 2015/10/06 ...
5 years, 2 months ago (2015-10-06 14:17:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387173003/40001
5 years, 2 months ago (2015-10-06 14:17:35 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 14:24:07 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b0cd8b714629352638f17154cfc05ade03fff8f5

Powered by Google App Engine
This is Rietveld 408576698