Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1387143003: Add missing break in switch-case statements in gles2_cmd_decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test for checking clearing of backbuffer bits! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 3b45922c697f3ca0a0dc16125a005582064c124a..2aa9b379c6a8132f6b6b06592244ab2f84558ce6 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -901,6 +901,13 @@ class GLES2DecoderImpl : public GLES2Decoder, public ErrorStateClient {
uint32* service_texture_id) override;
uint32 GetTextureUploadCount() override;
+ // Methods added specifically for unit tests.
+ uint32 GetBackbufferClearBits() override {
+ return backbuffer_needs_clear_bits_;
+ }
+ void ClearBackbufferClearBits() override {
+ backbuffer_needs_clear_bits_ = 0;
+ }
base::TimeDelta GetTotalTextureUploadTime() override;
base::TimeDelta GetTotalProcessingCommandsTime() override;
void AddProcessingCommandsTime(base::TimeDelta) override;
@@ -5154,6 +5161,7 @@ void GLES2DecoderImpl::DoDiscardFramebufferEXT(GLenum target,
break;
case GL_DEPTH_EXT:
backbuffer_needs_clear_bits_ |= GL_DEPTH_BUFFER_BIT;
+ break;
case GL_STENCIL_EXT:
backbuffer_needs_clear_bits_ |= GL_STENCIL_BUFFER_BIT;
break;
@@ -6481,6 +6489,7 @@ void GLES2DecoderImpl::DoGetRenderbufferParameteriv(
glGetRenderbufferParameterivEXT(target, GL_RENDERBUFFER_SAMPLES_EXT,
params);
}
+ break;
default:
glGetRenderbufferParameterivEXT(target, pname, params);
break;

Powered by Google App Engine
This is Rietveld 408576698