Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1387143003: Add missing break in switch-case statements in gles2_cmd_decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes to go through the clang compiler error! Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 41a78d20a00a1d3abdfd06af8ceee78492902f04..0b957479fb13c69b4ea303fafe5bdbc7e7ea1a8c 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -749,6 +749,10 @@ bool GLES2Decoder::GetServiceTextureId(uint32 client_texture_id,
return false;
}
+uint32 GLES2Decoder::GetAndClearBackbufferClearBitsForTest() {
+ return 0;
+}
+
GLES2Decoder::GLES2Decoder()
: initialized_(false),
debug_(false),
@@ -867,6 +871,7 @@ class GLES2DecoderImpl : public GLES2Decoder, public ErrorStateClient {
void SetIgnoreCachedStateForTest(bool ignore) override;
void SetForceShaderNameHashingForTest(bool force) override;
+ uint32 GetAndClearBackbufferClearBitsForTest() override;
void ProcessFinishedAsyncTransfers();
bool GetServiceTextureId(uint32 client_texture_id,
@@ -4910,6 +4915,13 @@ void GLES2DecoderImpl::SetForceShaderNameHashingForTest(bool force) {
force_shader_name_hashing_for_test = force;
}
+// Added specifically for testing backbuffer_needs_clear_bits unittests.
+uint32 GLES2DecoderImpl::GetAndClearBackbufferClearBitsForTest() {
+ uint32 clear_bits = backbuffer_needs_clear_bits_;
+ backbuffer_needs_clear_bits_ = 0;
+ return clear_bits;
+}
+
void GLES2DecoderImpl::OnFboChanged() const {
if (workarounds().restore_scissor_on_fbo_change)
state_.fbo_binding_for_scissor_workaround_dirty = true;
@@ -5130,6 +5142,7 @@ void GLES2DecoderImpl::DoDiscardFramebufferEXT(GLenum target,
break;
case GL_DEPTH_EXT:
backbuffer_needs_clear_bits_ |= GL_DEPTH_BUFFER_BIT;
+ break;
case GL_STENCIL_EXT:
backbuffer_needs_clear_bits_ |= GL_STENCIL_BUFFER_BIT;
break;
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698