Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder.h

Issue 1387143003: Add missing break in switch-case statements in gles2_cmd_decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test for checking clearing of backbuffer bits! Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file contains the GLES2Decoder class. 5 // This file contains the GLES2Decoder class.
6 6
7 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_ 7 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_
8 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_ 8 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_
9 9
10 #include <string> 10 #include <string>
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 240
241 // Sets the callback for fence sync release and wait calls. The wait call 241 // Sets the callback for fence sync release and wait calls. The wait call
242 // returns true if the channel is still scheduled. 242 // returns true if the channel is still scheduled.
243 virtual void SetFenceSyncReleaseCallback( 243 virtual void SetFenceSyncReleaseCallback(
244 const FenceSyncReleaseCallback& callback) = 0; 244 const FenceSyncReleaseCallback& callback) = 0;
245 virtual void SetWaitFenceSyncCallback( 245 virtual void SetWaitFenceSyncCallback(
246 const WaitFenceSyncCallback& callback) = 0; 246 const WaitFenceSyncCallback& callback) = 0;
247 247
248 virtual void WaitForReadPixels(base::Closure callback) = 0; 248 virtual void WaitForReadPixels(base::Closure callback) = 0;
249 virtual uint32 GetTextureUploadCount() = 0; 249 virtual uint32 GetTextureUploadCount() = 0;
250 virtual uint32 GetBackbufferClearBits() { return 0; }
Sami 2015/11/04 11:55:52 Please add the "ForTest" suffix for these to make
RaviKasibhatla 2015/11/04 14:59:40 Done.
251 virtual void ClearBackbufferClearBits() {}
250 virtual base::TimeDelta GetTotalTextureUploadTime() = 0; 252 virtual base::TimeDelta GetTotalTextureUploadTime() = 0;
251 virtual base::TimeDelta GetTotalProcessingCommandsTime() = 0; 253 virtual base::TimeDelta GetTotalProcessingCommandsTime() = 0;
252 virtual void AddProcessingCommandsTime(base::TimeDelta) = 0; 254 virtual void AddProcessingCommandsTime(base::TimeDelta) = 0;
253 255
254 // Returns true if the context was lost either by GL_ARB_robustness, forced 256 // Returns true if the context was lost either by GL_ARB_robustness, forced
255 // context loss or command buffer parse error. 257 // context loss or command buffer parse error.
256 virtual bool WasContextLost() const = 0; 258 virtual bool WasContextLost() const = 0;
257 259
258 // Returns true if the context was lost specifically by GL_ARB_robustness. 260 // Returns true if the context was lost specifically by GL_ARB_robustness.
259 virtual bool WasContextLostByRobustnessExtension() const = 0; 261 virtual bool WasContextLostByRobustnessExtension() const = 0;
(...skipping 17 matching lines...) Expand all
277 bool log_commands_; 279 bool log_commands_;
278 bool unsafe_es3_apis_enabled_; 280 bool unsafe_es3_apis_enabled_;
279 281
280 DISALLOW_COPY_AND_ASSIGN(GLES2Decoder); 282 DISALLOW_COPY_AND_ASSIGN(GLES2Decoder);
281 }; 283 };
282 284
283 } // namespace gles2 285 } // namespace gles2
284 } // namespace gpu 286 } // namespace gpu
285 287
286 #endif // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_ 288 #endif // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698