third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODOs to replace the members with const members Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

index 3a063cb536363d4270542dee769b14eab99a2ed5..296806107e61d9fe3f60367fe4802219ec2c42d8 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -808,7 +808,7 @@ PassRefPtrWillBeRawPtr<ShapeValue> StyleBuilderConverter::convertShapeValue(Styl

}

if (value->isImageValue() || value->isImageGeneratorValue() || value->isImageSetValue())

- return ShapeValue::createImageValue(state.styleImage(CSSPropertyShapeOutside, value));

+ return ShapeValue::createImageValue(state.styleImage(CSSPropertyShapeOutside, *value));

RefPtr<BasicShape> shape;

CSSBoxType cssBox = BoxMissing;