third_party/WebKit/Source/core/css/CSSImageValue.h - Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.h

Issue 1387113002: Change StyleResolverState.styleImage() to take a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODOs to replace the members with const members Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSImageSetValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSImageValue.cpp » ('j') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSImageValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.h b/third_party/WebKit/Source/core/css/CSSImageValue.h

index f3f827cf8dfb91c62cf5c422bb24d2d82fc02170..5ec97cdb92790aa4bd3cb4656906b34b305f06ff 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.h

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.h

@@ -51,7 +51,7 @@ public:

~CSSImageValue();

bool isCachePending() const { return m_isCachePending; }

- StyleFetchedImage* cachedImage() { ASSERT(!isCachePending()); return m_cachedImage.get(); }

+ StyleFetchedImage* cachedImage() const { ASSERT(!isCachePending()); return m_cachedImage.get(); }

StyleFetchedImage* cacheImage(Document*, const ResourceLoaderOptions&);

StyleFetchedImage* cacheImage(Document* document) { return cacheImage(document, ResourceFetcher::defaultResourceOptions()); }

@@ -78,7 +78,7 @@ public:

void setInitiator(const AtomicString& name) { m_initiatorName = name; }

DECLARE_TRACE_AFTER_DISPATCH();

- void restoreCachedResourceIfNeeded(Document&);

+ void restoreCachedResourceIfNeeded(Document&) const;

private:

CSSImageValue(const AtomicString& rawValue, const KURL&, StyleFetchedImage*);