Issue 13871010: Explicitly free the web contents in the background contents destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13871010: Explicitly free the web contents in the background contents destructor. (Closed)

Created:
7 years, 8 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 8 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Explicitly free the web contents in the background contents destructor. This will help track down what's going on in crbug.com/164617 - is it a double-free of the BackgroundContents, or an unexpected free of the WebContents? This is a re-land of r194345 BUG=164617 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194361

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/tab_contents/background_contents.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

7 years, 8 months ago (2013-04-16 14:21:46 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r194361 (presubmit successful).

Expand Messages | Collapse Messages