Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1387043002: Make dart:_vmservice a proper builtin library (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make dart:_vmservice a proper builtin library - Drops custom resource table for sources. - Stops loading dart:vmservice library by sources. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/af0ab36f7ca370e950ebcc9bb67b13bbae3c98f5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -830 lines) Patch
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/mirrors.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download
A + runtime/lib/vmservice/client.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/constants.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/message.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/message_router.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/running_isolate.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/running_isolates.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/vmservice/vmservice.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/lib/vmservice_sources.gypi View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
D runtime/vm/service/client.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D runtime/vm/service/constants.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D runtime/vm/service/message.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D runtime/vm/service/message_router.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D runtime/vm/service/running_isolate.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/vm/service/running_isolates.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/vm/service/vmservice.dart View 1 chunk +0 lines, -331 lines 0 comments Download
M runtime/vm/service_isolate.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 5 chunks +4 lines, -165 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +26 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 2 months ago (2015-10-05 22:29:28 UTC) #2
rmacnak
lgtm w/c Censor it in runtime/lib/mirrors.cc CreateLibraryMirror Worth testing on Dartium before landing
5 years, 2 months ago (2015-10-05 22:46:46 UTC) #3
Cutch
On 2015/10/05 22:46:46, rmacnak wrote: > lgtm w/c > > Censor it in runtime/lib/mirrors.cc CreateLibraryMirror ...
5 years, 2 months ago (2015-10-06 14:39:36 UTC) #4
Cutch
5 years, 2 months ago (2015-10-06 14:58:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
af0ab36f7ca370e950ebcc9bb67b13bbae3c98f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698