Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 138703002: IndexedDB: Replace passing identically-sized vectors with pairs (Closed)

Created:
6 years, 11 months ago by jsbell
Modified:
6 years, 11 months ago
Reviewers:
Tom Sepez, alecflett
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: Replace passing identically-sized vectors with pairs Avoid the antipattern of passing vectors-that-must-be-the-same-size. Use a tuple (well, a pair) instead. R=tsepez@chromium.org,alecflett@chromium.org BUG=334314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245383

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -78 lines) Patch
M content/browser/indexed_db/indexed_db_database.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 3 chunks +0 lines, -22 lines 0 comments Download
M content/browser/indexed_db/indexed_db_index_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_index_writer.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
tsepez@, alecflett@ - please take a look?
6 years, 11 months ago (2014-01-14 19:09:30 UTC) #1
Tom Sepez
Messages LGTM. Thanks for doing it this way.
6 years, 11 months ago (2014-01-14 19:13:20 UTC) #2
alecflett
lgtm
6 years, 11 months ago (2014-01-16 22:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/138703002/120001
6 years, 11 months ago (2014-01-16 22:36:38 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 23:55:12 UTC) #5
Message was sent while issue was closed.
Change committed as 245383

Powered by Google App Engine
This is Rietveld 408576698