Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: device/bluetooth/bluetooth_device.h

Issue 13870020: Bluetooth: Add support for pairing display notifications (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index bb363f9083e1880234207a74c1ea0d4616c2c24e..9db044350c803b0078aee541cbc794d919679eab 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -123,6 +123,19 @@ class BluetoothDevice {
virtual void DisplayPasskey(BluetoothDevice* device,
uint32 passkey) = 0;
+ // This method will be called when the Bluetooth daemon gets a notification
+ // of a key entered in the device |device| while pairing with the device
keybuk 2013/04/17 23:43:37 nit: "on" the device
deymo 2013/04/18 00:26:01 Done.
+ // using a PIN code or a Passkey. This method will be called only after
keybuk 2013/04/17 23:43:37 nit: paragraph/line break here to de-dense the tex
deymo 2013/04/18 00:26:01 Right now, with the current BlueZ, no, it is never
+ // DisplayPinCode() or DisplayPasskey() is called and before the
+ // corresponding DismissDisplayOrConfirm() is called, but is not warrantied
keybuk 2013/04/17 23:43:37 nit: warranted
deymo 2013/04/18 00:26:01 Done.
+ // to be called on every pairing process that requires a PIN code or a
+ // Passkey because some device may not support this feature.
+ // The |entered| value describes the number of keys entered so far,
keybuk 2013/04/17 23:43:37 nit: paragraph/line break before this one
deymo 2013/04/18 00:26:01 Done.
+ // including the last [enter] key. A first call to DisplayEnteredKeys() with
+ // |entered| as 0 will be effectuated when the device supports this feature.
keybuk 2013/04/17 23:43:37 Isn't this only supported by DisplayPasskey? Or a
keybuk 2013/04/17 23:43:37 nit: replace effectuated with "sent" :)
deymo 2013/04/18 00:26:01 Yes, apple keyboard could be supported eventually
+ virtual void DisplayEnteredKeys(BluetoothDevice* device,
+ uint32 entered) = 0;
+
// This method will be called when the Bluetooth daemon requires that the
// user confirm that the Passkey |passkey| is displayed on the screen
// of the device |device| so that it may be authenticated. The delegate
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698