Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386963002: Add more .h files to the .gypi (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add more .h files to the .gypi BUG=skia: Committed: https://skia.googlesource.com/skia/+/1562855b1981a57b5c2e40554d8f9641d069060b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M gyp/core.gypi View 12 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
herb_g
5 years, 2 months ago (2015-10-05 19:52:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386963002/1
5 years, 2 months ago (2015-10-05 19:52:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 19:58:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386963002/1
5 years, 2 months ago (2015-10-05 20:26:40 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-05 20:26:42 UTC) #9
mtklein
lgtm
5 years, 2 months ago (2015-10-05 20:26:58 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:29:25 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1562855b1981a57b5c2e40554d8f9641d069060b

Powered by Google App Engine
This is Rietveld 408576698