Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: client/crashpad_client_mac.cc

Issue 1386943002: mac: Make UseSystemDefaultHandler() clear handlers on failure (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crashpad_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_client_mac.cc
diff --git a/client/crashpad_client_mac.cc b/client/crashpad_client_mac.cc
index e7ad064269f94acbd9fccf1bb1fd92005e12e32c..a180fd193e40a8384751a61a1ecda19ca8d2906f 100644
--- a/client/crashpad_client_mac.cc
+++ b/client/crashpad_client_mac.cc
@@ -221,13 +221,15 @@ bool CrashpadClient::UseHandler() {
}
// static
-bool CrashpadClient::UseSystemDefaultHandler() {
+void CrashpadClient::UseSystemDefaultHandler() {
base::mac::ScopedMachSendRight
system_crash_reporter_handler(SystemCrashReporterHandler());
// Proceed even if SystemCrashReporterHandler() failed, setting MACH_PORT_NULL
// to clear the current exception ports.
- return SetCrashExceptionPorts(system_crash_reporter_handler);
+ if (!SetCrashExceptionPorts(system_crash_reporter_handler)) {
+ SetCrashExceptionPorts(MACH_PORT_NULL);
+ }
}
} // namespace crashpad
« no previous file with comments | « client/crashpad_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698