Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1386943002: mac: Make UseSystemDefaultHandler() clear handlers on failure (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Make UseSystemDefaultHandler() clear handlers on failure If the task’s exception handler for EXC_CRASH, EXC_RESOURCE, and EXC_GUARD exceptions cannot be set, clear the handler instead. Nothing considered this function’s return value, and the only viable fallback action on failure would have been to do what the function now does, so its return type is changed to void. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c95b30464ac1bfb03ccc197ec761f481e0fac391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M client/crashpad_client.h View 1 chunk +5 lines, -8 lines 0 comments Download
M client/crashpad_client_mac.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-05 19:24:10 UTC) #2
Robert Sesek
lgtm
5 years, 2 months ago (2015-10-05 20:54:04 UTC) #3
Mark Mentovai
5 years, 2 months ago (2015-10-05 21:12:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c95b30464ac1bfb03ccc197ec761f481e0fac391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698