content/browser/download/mhtml_generation_manager.h - Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-generation-mgr-cleanup

Patch Set: Rebasing... Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/mhtml_generation_manager.cc » ('j') | content/browser/download/mhtml_generation_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/mhtml_generation_manager.h

diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h

index e13ca60087d9b2c7554d7b61f42b579a76514fab..db07312014184e4d1d6a974f0a33fc85808fcb6f 100644

--- a/content/browser/download/mhtml_generation_manager.h

+++ b/content/browser/download/mhtml_generation_manager.h

@@ -6,6 +6,7 @@

#define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_

#include <map>

+#include <string>

Randy Smith (Not in Mondays) 2015/12/10 23:07:55 Ok, I'll bite. I don't see any use of std::string

lukasza 2015/12/11 00:29:03 I don't know how that happened :-/ Removed / don

Łukasz Anforowicz 2015/12/14 18:08:42 Ah, I think I need this include in the next CL and

#include "base/files/file.h"

#include "base/memory/singleton.h"