content/renderer/render_view_impl.cc - Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-generation-mgr-cleanup

Patch Set: Addressed CR feedback from dcheng@. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_manager.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | content/renderer/web_frame_utils.h » ('j') | third_party/WebKit/Source/web/WebPageSerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index e71d180ef1a53ecfa2dcc0d07f65180fc60435aa..6ca1c3d90a5443fec33a4fb35690067cbe24b6bd 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -85,7 +85,6 @@

#include "content/renderer/internal_document_state_data.h"

#include "content/renderer/media/audio_device_factory.h"

#include "content/renderer/media/video_capture_impl_manager.h"

-#include "content/renderer/mhtml_generator.h"

#include "content/renderer/mojo_bindings_controller.h"

#include "content/renderer/navigation_state_impl.h"

#include "content/renderer/net_info_helper.h"

@@ -783,7 +782,6 @@ void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,

OnEnableAutoResize(params.min_size, params.max_size);

}

- new MHTMLGenerator(this);

#if defined(OS_MACOSX)

new TextInputClientObserver(this);

#endif // defined(OS_MACOSX)