content/renderer/render_frame_impl.h - Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-generation-mgr-cleanup

Patch Set: Addressed CR feedback from dcheng@. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_manager.cc ('K') | « content/renderer/mhtml_generator.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/web/WebPageSerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 374e09da4cc2ee365a7f7427458e6294badf2c7f..7e6136ca9c84ae918904db259cca924232576f58 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -25,6 +25,7 @@

#include "content/renderer/render_frame_proxy.h"

#include "content/renderer/renderer_webcookiejar_impl.h"

#include "ipc/ipc_message.h"

+#include "ipc/ipc_platform_file.h"

#include "media/blink/webmediaplayer_delegate.h"

#include "media/blink/webmediaplayer_params.h"

#include "mojo/application/public/interfaces/service_provider.mojom.h"

@@ -770,6 +771,12 @@ class CONTENT_EXPORT RenderFrameImpl

std::vector<GURL> original_urls,

std::vector<base::FilePath> equivalent_local_paths,

base::FilePath local_directory_path);

+ void OnSerializeAsMHTML(

+ int job_id,

+ IPC::PlatformFileForTransit file_for_transit,

+ const std::string& mhtml_boundary_marker,

+ const std::map<int, std::string>& frame_routing_id_to_content_id,

+ bool is_last_frame);

// Requests that the browser process navigates to |url|. If

// |is_history_navigation_in_new_child| is true, the browser process should