third_party/WebKit/Source/web/tests/MHTMLTest.cpp - Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

Issue 1386873003: OOPIFs: Transitioning MHTML generation from view-oriented to frame-oriented. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mhtml-generation-mgr-cleanup

Patch Set: Moved MHTML boundary marker generation into the browser. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebPageSerializer.cpp ('K') | « third_party/WebKit/Source/web/WebPageSerializer.cpp ('k') | third_party/WebKit/public/web/WebPageSerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

index 4aef940df81f40b738d5ec6c44bc58cd258cbe92..569c3cddbdc5c74689049433bb057b2c6c1d0655 100644

--- a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

+++ b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp

@@ -145,7 +145,9 @@ protected:

MHTMLArchive::EncodingPolicy encodingPolicy,

const String& title, const String& mimeType)

{

- String boundary = MHTMLArchive::generateMHTMLBoundary();

+ // This boundary is as good as any other. Plus it gets used in almost

+ // all the examples in the MHTML spec - RFC 2557.

+ String boundary = String::fromUTF8("boundary-example");

RefPtr<SharedBuffer> mhtmlData = SharedBuffer::create();

MHTMLArchive::generateMHTMLHeader(boundary, title, mimeType, *mhtmlData);