Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1386863002: Revert "[heap] No leakage of mark-compact.h outside of heap." (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[heap] No leakage of mark-compact.h outside of heap." The change in question caused regressions on GC-heavy benchmarks, presumably due to the added indirection that is taken within hot code like the marking visitor. This is a manual revert due to conflicts. This reverts commit 4f55b83012247148e7040771bdcfccaea352201a. R=hpayer@chromium.org BUG=chromium:539273 LOG=n Committed: https://crrev.com/871529b4d86c406b4139129f138d88177a728a09 Cr-Commit-Position: refs/heads/master@{#31097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -31 lines) Patch
M src/heap/heap.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 10 chunks +14 lines, -21 lines 0 comments Download
M src/heap/incremental-marking.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-05 08:18:38 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-05 08:46:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386863002/1
5 years, 2 months ago (2015-10-05 12:11:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 12:14:04 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 12:14:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/871529b4d86c406b4139129f138d88177a728a09
Cr-Commit-Position: refs/heads/master@{#31097}

Powered by Google App Engine
This is Rietveld 408576698