bindings: Implements the named properties object (WindowProperties).

bindings: Implements the named properties object (WindowProperties).

Adds WindowProperties (named properties obejct) and change the prototype chain of Window accordingly.

The prototype chain of Window is:
window.__proto__ => Window.prototype
window.__proto__.__proto__ => WindowProperties object
window.__proto__.__proto__.__proto__ => EventTarget.prototype

The indexed properties were installed on Window.prototype, but I think it's meaningless, and moved it to the instance object as same as other objects.

BUG=516274
Committed: https://crrev.com/7390dfca9479cc4ff825b1d163ba7fb5aaa6076c
Cr-Commit-Position: refs/heads/master@{#352542}

[Yuki, 2015-10-06 03:47:01]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2015-10-06 03:47:02]

Could you review this CL?

[haraken, 2015-10-06 04:00:58]

https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:596:
'has_named_properties_object': is_global and context['named_property_getter'],

Why do we need the "and context['named_property_getter']" condition?

[Yuki, 2015-10-06 04:09:52]

https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:596:
'has_named_properties_object': is_global and context['named_property_getter'],
On 2015/10/06 04:00:57, haraken wrote:
> 
> Why do we need the "and context['named_property_getter']" condition?

The named properties object must exists if and only if
- the interface is [PrimaryGlobal] or [Global], and
- the interface implements the named properties.

context['named_property_getter'] can be None or empty string, and in that case,
there is no named property support.  Then we shouldn't install the named
properties object.

Note that existing workers do not support named properties so far.  In future,
we may introduce workers which support named properties.

[haraken, 2015-10-06 04:11:10]

On 2015/10/06 04:09:52, Yuki wrote:
>
https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):
> 
>
https://codereview.chromium.org/1386843002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/scripts/v8_interface.py:596:
> 'has_named_properties_object': is_global and context['named_property_getter'],
> On 2015/10/06 04:00:57, haraken wrote:
> > 
> > Why do we need the "and context['named_property_getter']" condition?
> 
> The named properties object must exists if and only if
> - the interface is [PrimaryGlobal] or [Global], and
> - the interface implements the named properties.
> 
> context['named_property_getter'] can be None or empty string, and in that
case,
> there is no named property support.  Then we shouldn't install the named
> properties object.
> 
> Note that existing workers do not support named properties so far.  In future,
> we may introduce workers which support named properties.

Makes sense. LGTM

[Yuki, 2015-10-06 04:12:46]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-10-06 04:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386843002/40001

[Yuki, 2015-10-06 04:14:08]

The CQ bit was unchecked by yukishiino@chromium.org

[Yuki, 2015-10-06 04:25:01]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2015-10-06 04:25:01]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1386843002/#ps60001
(title: "Updated IDL test results.")

[commit-bot: I haz the power, 2015-10-06 04:25:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386843002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386843002/60001

[commit-bot: I haz the power, 2015-10-06 05:37:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-06 05:38:30]

Patchset 4 (id:??) landed as
https://crrev.com/7390dfca9479cc4ff825b1d163ba7fb5aaa6076c
Cr-Commit-Position: refs/heads/master@{#352542}