Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: rlz/lib/financial_ping.cc

Issue 13868016: Detect when chrome is shutting down and don't SendFinacialPing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use alternate method for recognizing and handling shutdown Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/rlz/rlz.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/lib/financial_ping.cc
diff --git a/rlz/lib/financial_ping.cc b/rlz/lib/financial_ping.cc
index 48c446ecb3c8e405d0c37f3a4bbf298bde1047f7..25d9e75167c8b475498212b3ee426a8c11d58f3e 100644
--- a/rlz/lib/financial_ping.cc
+++ b/rlz/lib/financial_ping.cc
@@ -265,6 +265,10 @@ bool FinancialPing::PingServer(const char* request, std::string* response) {
return true;
#else
+ // Browser shutdown will cause the context to be reset to NULL.
+ if (!g_context)
+ return false;
+
// Run a blocking event loop to match the win inet implementation.
scoped_ptr<MessageLoop> message_loop;
// Ensure that we have a MessageLoop.
@@ -288,7 +292,6 @@ bool FinancialPing::PingServer(const char* request, std::string* response) {
// Ensure rlz_lib::SetURLRequestContext() has been called before sending
// pings.
- CHECK(g_context);
fetcher->SetRequestContext(g_context);
const base::TimeDelta kTimeout = base::TimeDelta::FromMinutes(5);
« no previous file with comments | « chrome/browser/rlz/rlz.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698