Do not animate detaching / undetaching the bookmark bar in immersive mode

Do not animate detaching / undetaching the bookmark bar in immersive mode.

This CL also fixes a visual pop at the end of the bookmark bar slide in animation because the top container height is incorrectly computed.

BUG=235041
Test=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196899

[pkotwicz, 2013-04-25 21:40:46]

James, can you please take a look?

[James Cook, 2013-04-25 21:45:21]

LGTM with optional nit

https://codereview.chromium.org/13868010/diff/4001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/13868010/diff/4001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.cc:725: bool
to_or_from_detached_state = (new_state == BookmarkBar::DETACHED) ||
optional nit: This variable name is fine, but long. detached_changed? 
detached_state_changed?

https://codereview.chromium.org/13868010/diff/4001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/top_container_view.cc (right):

https://codereview.chromium.org/13868010/diff/4001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/top_container_view.cc:39: // be above the bottom
of the toolbar while the bookmark bar is animating.
Good catch.

[commit-bot: I haz the power, 2013-04-26 20:07:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/13868010/11001

[commit-bot: I haz the power, 2013-04-27 00:27:31]

Change committed as 196899